Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: incorrect balance when no tracer in predecessors #558

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Nov 11, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe requested a review from yihuang November 11, 2024 01:35
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 46.21%. Comparing base (836617d) to head (12ce894).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
x/evm/keeper/grpc_query.go 78.12% 5 Missing and 2 partials ⚠️
rpc/types/utils.go 0.00% 4 Missing ⚠️
types/dynamic_fee.go 0.00% 2 Missing ⚠️
x/evm/types/codec.go 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #558      +/-   ##
===========================================
+ Coverage    46.18%   46.21%   +0.03%     
===========================================
  Files          181      181              
  Lines        18120    18132      +12     
===========================================
+ Hits          8368     8380      +12     
  Misses        9036     9036              
  Partials       716      716              
Files with missing lines Coverage Δ
x/evm/types/codec.go 38.29% <75.00%> (ø)
types/dynamic_fee.go 0.00% <0.00%> (ø)
rpc/types/utils.go 0.00% <0.00%> (ø)
x/evm/keeper/grpc_query.go 78.30% <78.12%> (+0.48%) ⬆️

@mmsqe mmsqe merged commit c9e06fa into crypto-org-chain:develop Nov 11, 2024
37 of 39 checks passed
@yihuang yihuang deleted the fix_tracer branch November 11, 2024 02:18
yihuang pushed a commit that referenced this pull request Nov 13, 2024
* Problem: incorrect balance when no tracer in predecessors (#558)

* Problem: incorrect balance when no tracer in predecessors

* lint

* Problem: wrong gas price when using basefee of minus one height when trace tx (#559)

* Problem: wrong gas price when using basefee of minus one height when trace tx

* add basefee req

---------

Signed-off-by: mmsqe <[email protected]>

* fix test

---------

Signed-off-by: mmsqe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants