Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: recent bug fixes are not included (backport: #558 #559) #561

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Nov 12, 2024

  • Problem: incorrect balance when no tracer in predecessors

  • lint

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

* Problem: incorrect balance when no tracer in predecessors

* lint
@mmsqe mmsqe requested a review from yihuang November 12, 2024 13:15
…trace tx (evmos#559)

* Problem: wrong gas price when using basefee of minus one height when trace tx

* add basefee req

---------

Signed-off-by: mmsqe <[email protected]>
@mmsqe mmsqe changed the title Problem: incorrect balance when no tracer in predecessors (backport: #558) Problem: recent bug fixes are not included (backport: #558 #559) Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 24 lines in your changes missing coverage. Please review.

Project coverage is 63.17%. Comparing base (f6d137b) to head (866c741).
Report is 1 commits behind head on release/v0.22.x-cronos.

Files with missing lines Patch % Lines
x/evm/keeper/grpc_query.go 65.85% 10 Missing and 4 partials ⚠️
rpc/types/utils.go 0.00% 4 Missing ⚠️
rpc/backend/tracing.go 40.00% 2 Missing and 1 partial ⚠️
types/dynamic_fee.go 0.00% 2 Missing ⚠️
x/evm/types/codec.go 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           release/v0.22.x-cronos     #561      +/-   ##
==========================================================
- Coverage                   63.18%   63.17%   -0.01%     
==========================================================
  Files                         130      130              
  Lines                       12363    12389      +26     
==========================================================
+ Hits                         7811     7827      +16     
- Misses                       4040     4047       +7     
- Partials                      512      515       +3     
Files with missing lines Coverage Δ
x/evm/types/codec.go 87.23% <75.00%> (ø)
types/dynamic_fee.go 0.00% <0.00%> (ø)
rpc/backend/tracing.go 56.75% <40.00%> (-0.47%) ⬇️
rpc/types/utils.go 0.00% <0.00%> (ø)
x/evm/keeper/grpc_query.go 78.06% <65.85%> (-0.47%) ⬇️

@yihuang yihuang merged commit 88afe81 into crypto-org-chain:release/v0.22.x-cronos Nov 13, 2024
29 of 33 checks passed
@yihuang yihuang deleted the release/v0.22.x-cronos_trace branch November 13, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants