Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: nil pointer error with legacy tx format #562

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Nov 14, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yihuang yihuang requested a review from mmsqe November 14, 2024 07:47
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <[email protected]>
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 46.18%. Comparing base (4fb45a3) to head (6e29acd).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
x/evm/types/eth.go 0.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #562      +/-   ##
===========================================
- Coverage    46.20%   46.18%   -0.02%     
===========================================
  Files          181      181              
  Lines        18146    18151       +5     
===========================================
- Hits          8384     8383       -1     
- Misses        9043     9048       +5     
- Partials       719      720       +1     
Files with missing lines Coverage Δ
x/evm/types/eth.go 43.66% <0.00%> (-4.83%) ⬇️

@yihuang yihuang enabled auto-merge (squash) November 14, 2024 08:06
@yihuang yihuang merged commit 6464c22 into crypto-org-chain:develop Nov 14, 2024
37 of 39 checks passed
@yihuang yihuang deleted the develop branch November 14, 2024 08:12
yihuang added a commit that referenced this pull request Nov 14, 2024
* Problem: nil pointer error with legacy tx format

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

---------

Signed-off-by: yihuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants