Create release-notes-1.0.0.md #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sirmorrison
suggested changes
Oct 9, 2023
| ## Available Features | ||
|
|
||
| - Multi-Coin support - Native SPV wallets for Decred, Bitcoin and Litecoin. | ||
| - Coin Control - It allows users to select exact addresses and outputs to be used in a transaction. |
There was a problem hiding this comment.
Suggested change
| - Coin Control - It allows users to select exact addresses and outputs to be used in a transaction. | |
| - Coin Control - It allows users to select exact addresses and outputs to be used in a transaction. |
|
|
||
| ## Verifying the Release | ||
|
|
||
| In order to verify the release, you'll need to have `gpg` or `gpg2` installed on your system. Once you've obtained a copy (and hopefully verified that as well), you'll first need to import the keys that have signed this release if you haven't done so already: |
There was a problem hiding this comment.
This sentence is confusing especially the last part. It looks disconnected.
There was a problem hiding this comment.
What do you think?
To verify the release, you must have either gpg or gpg2 installed on your system and import the keys that have signed this release. After installing gpg or gpg2, you can proceed with importing the key below if you haven't already done so:
There was a problem hiding this comment.
hmmm, not a bad rephrase, failing to see the issue with the original paragraph
There was a problem hiding this comment.
you'll first need to import the keys that have signed this release if you haven't done so already
I think @Sirmorrison was referring to this line. What keys? The key is just below the sentence but we can improve there.
There was a problem hiding this comment.
please take another look
dreacot
requested review from
Sirmorrison,
crux25,
itswisdomagain and
ukane-philemon
ukane-philemon
requested changes
Oct 12, 2023
|
|
||
| ## Verifying the Release | ||
|
|
||
| In order to verify the release, you'll need to have `gpg` or `gpg2` installed on your system. Once you've obtained a copy (and hopefully verified that as well), you'll first need to import the keys that have signed this release if you haven't done so already: |
There was a problem hiding this comment.
What do you think?
To verify the release, you must have either gpg or gpg2 installed on your system and import the keys that have signed this release. After installing gpg or gpg2, you can proceed with importing the key below if you haven't already done so:
ukane-philemon
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.