-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add segmented control layout #175
Conversation
17f13d3
to
be7b6af
Compare
Do we really need a segmented control widget? we currently have a widget similar to this that is used on the send page. |
They are both different control layouts, what you are referring to is a button. The segmented control is used several places in the app, seems reasonable to make it a widget |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay, but could be improved maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for what has been pointed out by other reviewers, the PR LGTM.
037bffc
to
727197a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and we are good to go.
Since we are now using this, we will need to depreciate the switch text widget. So I recommend using this widget on the send page so we can test the implementation so far. |
based on my original comment, i brought the segmented control widget out of my previous PR to make it non blocking. so trying to use it on another page takes us back the original problem
correct, the text widget would be deprecated, but not as part of this PR. the work on the send page can be done in another PR |
- create a decorated text widget - further code cleanup
727197a
to
450174f
Compare
This PR adds segmented control to the
cryptomaterial
package, i was working on this as part of #166, but due to some changes to that PR and the fact that several other layouts would be needing it, i decided to add it as a standalone implementation.This PR does not include the dragging animation which some segmented controls have, if it is desired it can be added at a later time. but for the sake of avoiding unnecessary delays, i have intentionally left it out