multi: update dex client #633

ukane-philemon · 2024-09-06T17:33:02Z

Closes #632

Signed-off-by: Philemon Ukane <[email protected]>

ukane-philemon · 2024-09-06T17:37:23Z

I've noticed a few issues that I'm unable to resolve atm:

The server and market selection on the dex market page no longer stack on top of every element on the page when the dropdown is expanded
The dex market page doesn't scroll downwards unless the scrollbar is used (noticed the same thing on the post bond step).
The order type selection on the order form should be directly under the order type collapsed view.

I think these issues arose after recent dropdown code changes and the gioui version update.

bugjt · 2024-09-07T04:38:17Z

I have solved it

I've noticed a few issues that I'm unable to resolve atm:

The server and market selection on the dex market page no longer stack on top of every element on the page when the dropdown is expanded

The dex market page doesn't scroll downwards unless the scrollbar is used (noticed the same thing on the post bond step).

The order type selection on the order form should be directly under the order type collapsed view.

I think these issues arose after recent dropdown code changes and the gioui version update.

ui/cryptomaterial/dropdown.go

ukane-philemon · 2024-09-07T23:43:11Z

#633 (comment) has been resolved by 756a6cf

Signed-off-by: Philemon Ukane <[email protected]>

JoeGruffins

Trading is not working on dextest, I'll look into why not.

Edit, I found the logs, and trading is working I forgot to build with an adjusted locktime

JoeGruffins · 2024-09-19T07:55:17Z

There aren't many logs, are the dex ones spitting out somewhere?

The LTC logs are very loud though:

2024-09-19 16:52:17.502 [INF] LTC: Attempting to fetch set of un-checkpointed filters at height=808, hash=fe01b65a007e4b8f3056891fe4bb81e136fee1cd9b9173efa7f7628ddb69bd4d
2024-09-19 16:52:17.503 [INF] LTC: Verified 1 filter header in the last 15.01s (height 808, 2024-09-19 16:52:17 +0900 JST)
2024-09-19 16:52:32.513 [INF] LTC: Processed 1 block in the last 15.01s (height 809, 2024-09-19 16:52:32 +0900 JST)

JoeGruffins · 2024-09-19T08:35:42Z

Seeing some weird stuff with bonds. It's spinning somewhere:

2024-09-19 08:31:58.934 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.934 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.945 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.946 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.946 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.946 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.946 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.957 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.958 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.958 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.958 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.958 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.973 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.974 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.974 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)

ukane-philemon · 2024-09-24T01:43:27Z

Seeing some weird stuff with bonds. It's spinning somewhere:

2024-09-19 08:31:58.934 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.934 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.945 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.946 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.946 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.946 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.946 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.957 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.958 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.958 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.958 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.958 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.973 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.974 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)
2024-09-19 08:31:58.974 [DBG] DEXC: Soon to expire bond found: acec8ef3f7b76c10742240bbbd02b5120e813e0b2a60aa4ee4a08d38f2c329d9:0 (dcr)

I've investigated this.

dcrdex checks for bond rotation every bondTickInterval (20 secs) in watchBonds and continues to log this until an okay bond has been posted. See: watchBonds -> bondStateOfDex -> where the log actually happens

Same thing happens when a newly expired bond is found.

JoeGruffins · 2024-09-24T05:15:12Z

dcrdex checks for bond rotation every bondTickInterval (20 secs)

In my logs its logging 4 times per millisecond. It should only be once every 20 seconds correct?

JoeGruffins · 2024-09-24T06:18:38Z

More odd logging, bot the number of times in a millisecond it happens and why it needs usdc.eth:

2024-09-24 06:16:15.007 [ERR] DEXC: couldn't find minimum lot size for usdc.eth
2024-09-24 06:16:15.007 [ERR] DEXC: couldn't find minimum lot size for usdc.eth
2024-09-24 06:16:15.007 [ERR] DEXC: couldn't find minimum lot size for usdt.eth
2024-09-24 06:16:15.007 [ERR] DEXC: couldn't find minimum lot size for usdt.eth
2024-09-24 06:16:15.008 [ERR] DEXC: couldn't find minimum lot size for eth
2024-09-24 06:16:15.008 [ERR] DEXC: couldn't find minimum lot size for usdc.eth
2024-09-24 06:16:15.008 [ERR] DEXC: couldn't find minimum lot size for usdc.eth
2024-09-24 06:16:15.008 [ERR] DEXC: couldn't find minimum lot size for usdt.eth
2024-09-24 06:16:15.008 [ERR] DEXC: couldn't find minimum lot size for usdt.eth
2024-09-24 06:16:15.008 [ERR] DEXC: couldn't find minimum lot size for eth
2024-09-24 06:16:15.008 [ERR] DEXC: couldn't find minimum lot size for usdc.eth
2024-09-24 06:16:15.008 [ERR] DEXC: couldn't find minimum lot size for usdc.eth
2024-09-24 06:16:15.008 [ERR] DEXC: couldn't find minimum lot size for usdt.eth
2024-09-24 06:16:15.008 [ERR] DEXC: couldn't find minimum lot size for usdt.eth

JoeGruffins · 2024-09-24T07:09:29Z

I put in some prints and it looks like func (pg *DEXMarketPage) exchange() *core.Exchange is being hit many times per millisecond. I guess this calls exchangeInfo on the client which is a pretty heavy operation. Can you cache this info maybe? The fact that it needs that info so often is also pretty suspicious.

ukane-philemon · 2024-09-24T11:45:51Z

. it looks like func (pg *DEXMarketPage) exchange() *core.Exchange is being hit many times per millisecond

Aha, thanks. that's the other place bondStateOfDex is being called causing the spamming logs.

Signed-off-by: Philemon Ukane <[email protected]>

JoeGruffins · 2024-09-25T04:48:21Z

It looks like something else is still being hammered:

2024-09-25 04:44:16.196 [TRC] DEXC: wallet status requested for unknown asset 42 -> dcr
2024-09-25 04:44:16.340 [TRC] DEXC: wallet status requested for unknown asset 42 -> dcr
2024-09-25 04:44:16.345 [TRC] DEXC: wallet status requested for unknown asset 42 -> dcr
2024-09-25 04:44:16.359 [TRC] DEXC: wallet status requested for unknown asset 42 -> dcr
2024-09-25 04:44:16.373 [TRC] DEXC: wallet status requested for unknown asset 42 -> dcr
2024-09-25 04:44:16.401 [TRC] DEXC: wallet status requested for unknown asset 42 -> dcr
2024-09-25 04:44:16.425 [TRC] DEXC: wallet status requested for unknown asset 42 -> dcr
2024-09-25 04:44:16.453 [TRC] DEXC: wallet status requested for unknown asset 42 -> dcr
2024-09-25 04:44:16.453 [TRC] DEXC: wallet status requested for unknown asset 42 -> dcr
2024-09-25 04:44:16.479 [TRC] DEXC: wallet status requested for unknown asset 42 -> dcr
2024-09-25 04:44:16.863 [TRC] DEXC: wallet status requested for unknown asset 42 -> dcr
2024-09-25 04:44:16.870 [TRC] DEXC: wallet status requested for unknown asset 42 -> dcr
2024-09-25 04:44:16.907 [TRC] DEXC: wallet status requested for unknown asset 42 -> dcr

JoeGruffins · 2024-09-25T05:43:09Z

When I navigate to the dex onboarding page, it calls func (pg *DEXOnboarding) bondAmountInfoDisplay(gtx C) D and func (pg *DEXOnboarding) bondAccountHasEnough() bool about 30 times instantly. Do you know why? Is that just how it is? Seems like resources are being wasted. I guess because The logic is inside the view constructors? Is this correct?

Seems it should calculate everything once and then use pointers to the results. Like, its's calculating the same bond amount 30 times here:

func (pg *DEXOnboarding) bondAmountInfoDisplay(gtx C) D {
	asset := pg.bondSourceWalletSelector.SelectedWallet()
	assetType := asset.GetAssetType()
	icon := pg.Theme.AssetIcon(assetType)
	bondAsset := pg.bondServer.bondAssets[assetType]
	bondsFeeBuffer := pg.AssetsManager.DexClient().BondsFeeBuffer(bondAsset.ID)
	return layout.Flex{Axis: layout.Horizontal}.Layout(gtx,
		layout.Rigid(func(gtx C) D {
			if icon == nil {
				return D{}
			}
			return layout.Inset{Right: 5}.Layout(gtx, icon.Layout20dp)
		}),
		layout.Rigid(pg.Theme.Label(values.TextSize16, calculateBondAmount(asset, bondAsset, pg.newTier, bondsFeeBuffer)).Layout),
	)
}

JoeGruffins

I think there's lots of room for optimizing code but otherwise I think it looks good. Can optimize now or later.

Signed-off-by: Philemon Ukane <[email protected]>

ukane-philemon added 4 commits September 6, 2024 10:41

libwallet/asset: update btc and dcr dexwallet with upstream changes

eb092ce

Signed-off-by: Philemon Ukane <[email protected]>

libwallet/asset: update dex wallet implementation

d143ee9

Signed-off-by: Philemon Ukane <[email protected]>

ui/page/dcrdex: handle actions for wallet and account dropdown

7581c6d

Signed-off-by: Philemon Ukane <[email protected]>

multi: handle dex copy action in HandleUserInteractions annd typo fix

1341418

Signed-off-by: Philemon Ukane <[email protected]>

bugjt mentioned this pull request Sep 7, 2024

fix dropdown and scroll issue ukane-philemon/cryptopower#1

Closed

JustinBeBoy force-pushed the update-dex-client branch from 0d95d17 to 1779424 Compare September 7, 2024 06:06

fix dropdown and scroll issue

756a6cf

JustinBeBoy force-pushed the update-dex-client branch from 1779424 to 756a6cf Compare September 7, 2024 08:50

dreacot reviewed Sep 7, 2024

View reviewed changes

ui/cryptomaterial/dropdown.go Show resolved Hide resolved

ukane-philemon added 2 commits September 10, 2024 05:49

multi: update dex implementation

2db84a9

Signed-off-by: Philemon Ukane <[email protected]>

handle dex mnemonic seed display

7b3143e

Signed-off-by: Philemon Ukane <[email protected]>

ukane-philemon force-pushed the update-dex-client branch from 80e0a86 to 7b3143e Compare September 10, 2024 18:44

JoeGruffins approved these changes Sep 19, 2024

View reviewed changes

cache exchange info

abbac44

Signed-off-by: Philemon Ukane <[email protected]>

JoeGruffins approved these changes Sep 25, 2024

View reviewed changes

use cache for bond fee

8619024

Signed-off-by: Philemon Ukane <[email protected]>

dreacot approved these changes Sep 25, 2024

View reviewed changes

dreacot merged commit 0493db9 into crypto-power:master Sep 25, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

multi: update dex client #633

multi: update dex client #633

ukane-philemon commented Sep 6, 2024

ukane-philemon commented Sep 6, 2024 •

edited

Loading

bugjt commented Sep 7, 2024

ukane-philemon commented Sep 7, 2024

JoeGruffins left a comment •

edited

Loading

JoeGruffins commented Sep 19, 2024 •

edited

Loading

JoeGruffins commented Sep 19, 2024 •

edited

Loading

ukane-philemon commented Sep 24, 2024

JoeGruffins commented Sep 24, 2024 •

edited

Loading

JoeGruffins commented Sep 24, 2024

JoeGruffins commented Sep 24, 2024

ukane-philemon commented Sep 24, 2024

JoeGruffins commented Sep 25, 2024

JoeGruffins commented Sep 25, 2024 •

edited

Loading

JoeGruffins left a comment

multi: update dex client #633

multi: update dex client #633

Conversation

ukane-philemon commented Sep 6, 2024

ukane-philemon commented Sep 6, 2024 • edited Loading

bugjt commented Sep 7, 2024

ukane-philemon commented Sep 7, 2024

JoeGruffins left a comment • edited Loading

Choose a reason for hiding this comment

JoeGruffins commented Sep 19, 2024 • edited Loading

JoeGruffins commented Sep 19, 2024 • edited Loading

ukane-philemon commented Sep 24, 2024

JoeGruffins commented Sep 24, 2024 • edited Loading

JoeGruffins commented Sep 24, 2024

JoeGruffins commented Sep 24, 2024

ukane-philemon commented Sep 24, 2024

JoeGruffins commented Sep 25, 2024

JoeGruffins commented Sep 25, 2024 • edited Loading

JoeGruffins left a comment

Choose a reason for hiding this comment

ukane-philemon commented Sep 6, 2024 •

edited

Loading

JoeGruffins left a comment •

edited

Loading

JoeGruffins commented Sep 19, 2024 •

edited

Loading

JoeGruffins commented Sep 19, 2024 •

edited

Loading

JoeGruffins commented Sep 24, 2024 •

edited

Loading

JoeGruffins commented Sep 25, 2024 •

edited

Loading