Add HitBTC, Cryptopia and some other exchange IDs #148
Conversation
Add support for depositing assets requiring a memo
|
Do you have any plans to contribute any of these exchanges back? :-) I prefer to first add a few more exchange backends before adding more. It seems kind of unfair for me to just keep adding IDs to my project for which I won't see any other code contributions... |
|
Nice, thank you! I will try to review this PR and also test it out in the next few days... |
cryptoeax
changed the title
|
How well is HitBTC working for you currently? |
|
Not good, many things in CCXT adapter not compatable. And i build my own branch with updated CCXT. About HitBTC you can see code in my profile |
|
Can you please submit a PR for the CCXTAdapter fixes you made too? This one only includes 8ad9a4b as far as I can see. Thanks! |
|
(I'd like to test the exchange before merging it, so having something that works would be really helpful.) |
|
How well does Cryptopia work? I really wish you didn't mix multiple exchange backends in the same PR. This makes it impossible to merge your PR as is without me spending weeks to test both HitBTC and Cryptopia and make sure they are both bug free. :-( Just to make sure you aren't expecting a fast turn around, each exchange being tested takes quite a long time, and keeping them in separate PRs would have helped me merge the one that is ready first. |
cryptoeax
changed the title
|
Please avoid adding any other features to this PR. If you have other changes to contribute, please spend some time to make separate PRs for them. Thanks! |
|
|
||
| } | ||
|
|
||
| // Changed functions! |
There was a problem hiding this comment.
Why have you made these changes?
There was a problem hiding this comment.
your adapter not universal! and have specific code
bot/xchange/Cryptopia.php
Outdated
| return null; | ||
| } | ||
| $amount_fee = round($amount * $fee, $precisions[ 'amount' ]); | ||
| print( $this->prefix() . "INFO BUY [$tradeable]:\n" ); |
There was a problem hiding this comment.
Can you please remove the debugging statements from your code before submitting? Thanks!
No description provided.