-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: first draft to display meta data #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I have only a few remarks:
- Move everything below the example, so the example stays the first thing to bee seen.
- Don't use h2, but a less big heading.
- I'd expect the source code under the heading "sources" not the references
- I'd expect "Version History" instead of "changes to this example"
- I'd expect reviews to be a separate heading.
@kmindi As discussed. The jekyll-last-modified-at plugin is not available on github page (github/pages-gem#119) So, one have to enter the date oneself. However, I copy this value to Note, the spelling mistake in the screenshot was fixed (Reviewes). If you like to have other names for the headings, feel free to change them on this branch. |
_layouts/page.html
Outdated
{% assign site.last_updated = page.last_updated %} | ||
{% if page.references %} | ||
<ul> | ||
<h3>References</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move outside of ul
_layouts/page.html
Outdated
{% endif %} | ||
|
||
{% if page.current_reviews %} | ||
<h3>Last Reviews</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviews (not Last Reviews)
The html is not perfect. But IMO for the Prozessanalyse sufficient.
The syntax includes everything which was required/discussed on 27th March (sources, author name, author url, reviewers' names/company/..., link to reviewers' webpage, reviewed commits). Security Features can be realized by using tags.
Syntax for md files, here as part of
java_easy_AES_string_encryption.md
:Yields this page: