Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed version specifier for dependency-check/Change used JDK version #46

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

JaniruTEC
Copy link
Contributor

@JaniruTEC JaniruTEC commented Feb 1, 2024

See: cryptomator/cryptofs#202 (comment)

This PR corrects #45.

Summary by CodeRabbit

  • Chores
    • Updated the Java version used in dependency checks to enhance security and performance.

Copy link

coderabbitai bot commented Feb 1, 2024

Walkthrough

This update signifies a significant leap in the Java version used within the dependency-check.yml workflow, moving from Java 11 to Java 21. This change is aimed at ensuring compatibility with newer Java standards and improving the overall build process by leveraging the advancements and features introduced in the latest Java versions.

Changes

File Path Change Summary
.github/workflows/dependency-check.yml Updated Java version from 11 to 21

Related issues

  • JDK version in README.md is outdated (should be 21 now) cryptomator#3277: The update to Java 21 in the workflow file aligns with the objective to update the JDK version mentioned in the README.md from 19 to 21, ensuring compatibility and successful building with the latest JDK version. This issue could be linked as the changes contribute to maintaining consistent Java version requirements across the project.

🐇✨
In the realm of code where the Java beans grow,
A leap from eleven to twenty-one, oh!
With each version, we hop, skip, and jump,
For smoother builds, we conquer the bump.
🌟🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Member

@infeo infeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update workflow to use JDK 21

@JaniruTEC

This comment was marked as off-topic.

This comment was marked as off-topic.

@JaniruTEC JaniruTEC changed the title Changed version specifier for dependency-check Changed version specifier for dependency-check/Change used JDK version Feb 2, 2024
@JaniruTEC JaniruTEC requested a review from infeo February 2, 2024 19:24
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 40554e6 and 6e40b90.
Files selected for processing (1)
  • .github/workflows/dependency-check.yml (1 hunks)
Additional comments: 1
.github/workflows/dependency-check.yml (1)
  • 17-17: Ensure compatibility of the 'temurin' distribution with Java version 21, and verify that all steps in this workflow are compatible with the updated Java version.

@overheadhunter overheadhunter merged commit 2d284e0 into develop Feb 9, 2024
6 checks passed
@overheadhunter overheadhunter deleted the fix/dependency-check-version branch February 9, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants