Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encrypt and Decrypt wrappers for strings #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Encrypt and Decrypt wrappers for strings #2

wants to merge 1 commit into from

Conversation

nickboucher
Copy link
Member

Per #1

@nickboucher nickboucher added the enhancement New feature or request label Jun 21, 2019
@nickboucher nickboucher requested a review from swansonk14 June 21, 2019 00:13
@nickboucher
Copy link
Member Author

@swansonk14 please let me know if you see any issues or have suggestions before I merge :)

NCGThompson
NCGThompson approved these changes May 5, 2021
View reviewed changes
Copy link

@NCGThompson NCGThompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"using its ASCCII values" isn't technically correct, because old() accommodates unicode characters. (also "its" is misspelled.)

damgard_jurik/crypto.py
@@ -182,6 +182,14 @@ def encrypt_list(self, m_list: List[int]) -> List[EncryptedNumber]:
"""
return [self.encrypt(m) for m in m_list]

def encrypt_string(self, m: str) -> List[EncryptedNumber]:
"""Encrypts a string using it's ASCII values.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"using its ASCCII values" isn't exactly correct, because ord() accommodates unicode characters. (also "its" is misspelled.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NCGThompson NCGThompson NCGThompson approved these changes

@swansonk14 swansonk14 Awaiting requested review from swansonk14

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickboucher @NCGThompson