Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend) Only include direct parent bounds for associated types in traits. #1193

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

maximebuyse
Copy link
Contributor

Fixes #1159

In the case of an associated type inside a trait that has indirect bounds, we don't include the indirect bounds anymore (only the direct ones). This behaves better with backends and the information can still be reconstructed.

@maximebuyse maximebuyse requested a review from W95Psp December 17, 2024 15:44
Copy link
Collaborator

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just on small thing

frontend/exporter/src/traits.rs Outdated Show resolved Hide resolved
@maximebuyse maximebuyse added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit a598467 Dec 17, 2024
15 checks passed
@maximebuyse maximebuyse deleted the fix-1159 branch December 17, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Super-parent bounds of associated types in impls are inlined
2 participants