Kyber spec. #15
Merged
Kyber spec. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks, looks pretty good already.
I left some comments inline and there are some general things
- Run
cargo fmton the code - add .gitignore for Cargo.lock and target
- The hax issue after formatting are because the modules are resorted. This shouldn't happen but is a known bug. Add empty lines between the module declarations in
lib.rs. Then you should be fine. - Error handling should be done consistently. Introduce an error enum or use
u8with error codes and onlyunwrapwhen you are certain that the call can't error. Each of these cases will need a proof.
…tests and comments).
franziskuskiefer
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.