Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ml-kem extraction for NSS #226

Merged
merged 7 commits into from
Apr 4, 2024
Merged

Update ml-kem extraction for NSS #226

merged 7 commits into from
Apr 4, 2024

Conversation

franziskuskiefer
Copy link
Member

@franziskuskiefer franziskuskiefer commented Apr 3, 2024 •
edited
Loading

Update extraction for NSS and some more tests.

  • Add early wycheproof tests
  • While public key validation is recommended, it is not part of encaps. Hence I made encaps reduce the public key.

karthikbhargavan
karthikbhargavan approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@karthikbhargavan karthikbhargavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Is adding the reduction to encaps impacting performance?

@franziskuskiefer
Copy link
Member Author

Is adding the reduction to encaps impacting performance?

I couldn't measure any difference.

@franziskuskiefer franziskuskiefer marked this pull request as ready for review April 4, 2024 09:43
@franziskuskiefer franziskuskiefer merged commit 9f18bc4 into main Apr 4, 2024
15 checks passed
@franziskuskiefer franziskuskiefer deleted the franziskus/update-kyber-extraction branch April 4, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikbhargavan karthikbhargavan karthikbhargavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
libcrux
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franziskuskiefer @karthikbhargavan