-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored ML-KEM SIMD scaffolding #233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update some names but we can do that later. The F* is the only real issue we should fix.
This will need more hax changes. We will work on |
updated extraction with latest hax and fixed patches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of work in this PR, future PRs should be much smaller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot here that needs cleanup. But we'll do that in follow-ups.
I only reverted the sha3 changes. If that's something you want @karthikbhargavan, do them separately.
ugh, was a local experiment. should not have been pushed.
…On Sun, Apr 28, 2024, 20:35 Franziskus Kiefer ***@***.***> wrote:
***@***.**** approved this pull request.
There's a lot here that needs cleanup. But we'll do that in follow-ups.
I only reverted the sha3 changes. If that's something you want
@karthikbhargavan <https://github.com/karthikbhargavan>, do them
separately.
------------------------------
In libcrux-ml-kem/src/simd/mod.rs
<#233 (comment)>:
> @@ -0,0 +1,20 @@
+pub(crate) mod simd_trait;
+
+#[cfg(all(not(feature = "simd128"), not(feature = "simd256")))]
+mod portable;
Portable will always have to be built.
It's ok for now. I'll change that later.
------------------------------
In sys/hacl/c/src/Hacl_Hash_SHA3_Scalar.c
<#233 (comment)>:
> @@ -1158,14 +1158,12 @@ void Hacl_Hash_SHA3_Scalar_sha3_224(uint8_t *output, uint8_t *input, uint32_t in
uint64_t c = Hacl_Impl_SHA3_Vec_keccak_rndc[i0];
s[0U] = s[0U] ^ c;
}
+ uint8_t hbuf[200U] = { 0U };
What are these changes? They shouldn't be here.
—
Reply to this email directly, view it on GitHub
<#233 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFUVS3TJKY6UGH63RKUSQDY7U6OLAVCNFSM6AAAAABGVGB566VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRXGIYTCOBXG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
simd
directoryOperations
to provide a unified API over the different SIMD bit-widths and architectures*_int_vec_*
prefixes, suffixes, and affixes and renamed constants