Refactored ML-KEM SIMD scaffolding #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need more hax changes. We will work on |
updated extraction with latest hax and fixed patches
karthikbhargavan
approved these changes
Apr 28, 2024
franziskuskiefer
approved these changes
Apr 28, 2024
There was a problem hiding this comment.
There's a lot here that needs cleanup. But we'll do that in follow-ups.
I only reverted the sha3 changes. If that's something you want @karthikbhargavan, do them separately.
|
ugh, was a local experiment. should not have been pushed.
…On Sun, Apr 28, 2024, 20:35 Franziskus Kiefer ***@***.***> wrote:
***@***.**** approved this pull request.
There's a lot here that needs cleanup. But we'll do that in follow-ups.
I only reverted the sha3 changes. If that's something you want
@karthikbhargavan <https://github.com/karthikbhargavan>, do them
separately.
------------------------------
In libcrux-ml-kem/src/simd/mod.rs
<#233 (comment)>:
> @@ -0,0 +1,20 @@
+pub(crate) mod simd_trait;
+
+#[cfg(all(not(feature = "simd128"), not(feature = "simd256")))]
+mod portable;
Portable will always have to be built.
It's ok for now. I'll change that later.
------------------------------
In sys/hacl/c/src/Hacl_Hash_SHA3_Scalar.c
<#233 (comment)>:
> @@ -1158,14 +1158,12 @@ void Hacl_Hash_SHA3_Scalar_sha3_224(uint8_t *output, uint8_t *input, uint32_t in
uint64_t c = Hacl_Impl_SHA3_Vec_keccak_rndc[i0];
s[0U] = s[0U] ^ c;
}
+ uint8_t hbuf[200U] = { 0U };
What are these changes? They shouldn't be here.
—
Reply to this email directly, view it on GitHub
<#233 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFUVS3TJKY6UGH63RKUSQDY7U6OLAVCNFSM6AAAAABGVGB566VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRXGIYTCOBXG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simddirectoryOperationsto provide a unified API over the different SIMD bit-widths and architectures*_int_vec_*prefixes, suffixes, and affixes and renamed constants