Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avx2 extraction improvements #287

Merged
merged 7 commits into from
May 23, 2024
Merged

avx2 extraction improvements #287

merged 7 commits into from
May 23, 2024

Conversation

franziskuskiefer
Copy link
Member

@franziskuskiefer franziskuskiefer commented May 20, 2024 •
edited
Loading

This PR

  • adds a dummy module for the avx2 intrinsics in the polynomials crate for extraction of F* and C
  • moves mutable splits to the sha3 to allow F* extraction
  • fixes up some other places where the code didn't comply with hax

This also adds the extracted F* code.

@franziskuskiefer franziskuskiefer linked an issue May 22, 2024 that may be closed by this pull request
ml-kem: Move unsafe code to separate intrinsics module #252
Closed
@franziskuskiefer franziskuskiefer merged commit fa47313 into dev May 23, 2024
32 of 33 checks passed
@franziskuskiefer franziskuskiefer deleted the franziskus/avx2-extraction branch May 23, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikbhargavan karthikbhargavan karthikbhargavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
libcrux
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ml-kem: Move unsafe code to separate intrinsics module
2 participants
@franziskuskiefer @karthikbhargavan