Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract ML-KEM SIMD code to C #294

Closed
wants to merge 88 commits into from
Closed

Extract ML-KEM SIMD code to C #294

wants to merge 88 commits into from

Commits on May 20, 2024

  1. workarounds for charon

    @franziskuskiefer
    franziskuskiefer committed May 20, 2024
    Configuration menu
    Copy the full SHA
    8c02e75 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into franziskus/ml-kem-c-extraction

    @franziskuskiefer
    franziskuskiefer committed May 20, 2024
    Configuration menu
    Copy the full SHA
    594ad84 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. refactor: kill GenericOperations in favor of functions

    @W95Psp
    W95Psp committed May 21, 2024
    Configuration menu
    Copy the full SHA
    9d0c481 View commit details
    Browse the repository at this point in the history

  2. refactor: kill strings in unreachable

    @W95Psp
    W95Psp committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f85d218 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. inlining

    @W95Psp
    W95Psp committed May 24, 2024
    Configuration menu
    Copy the full SHA
    1dfd5d5 View commit details
    Browse the repository at this point in the history

  2. kill two debug_asserts that cause trait issues in Charon

    @W95Psp
    W95Psp committed May 24, 2024
    Configuration menu
    Copy the full SHA
    a2bc1fb View commit details
    Browse the repository at this point in the history

  3. commit C snapshot

    @W95Psp
    W95Psp committed May 24, 2024
    Configuration menu
    Copy the full SHA
    3b3164c View commit details
    Browse the repository at this point in the history

  4. wip

    @W95Psp
    W95Psp committed May 24, 2024
    Configuration menu
    Copy the full SHA
    2180172 View commit details
    Browse the repository at this point in the history

  5. wip

    @W95Psp
    W95Psp committed May 24, 2024
    Configuration menu
    Copy the full SHA
    d712003 View commit details
    Browse the repository at this point in the history

  6. update sha3 api to hide internal state

    @franziskuskiefer
    franziskuskiefer committed May 24, 2024
    Configuration menu
    Copy the full SHA
    8511062 View commit details
    Browse the repository at this point in the history

  7. add dummy intrinsics file for extraction of avx2

    @franziskuskiefer @W95Psp
    franziskuskiefer authored and W95Psp committed May 24, 2024
    Configuration menu
    Copy the full SHA
    886f965 View commit details
    Browse the repository at this point in the history

  8. F* extraction of poly-avx2

    @franziskuskiefer @W95Psp
    franziskuskiefer authored and W95Psp committed May 24, 2024
    Configuration menu
    Copy the full SHA
    35d28a0 View commit details
    Browse the repository at this point in the history

  9. move neon hash functions into sha3 for ml-kem

    @franziskuskiefer @W95Psp
    franziskuskiefer authored and W95Psp committed May 24, 2024
    Configuration menu
    Copy the full SHA
    5232b29 View commit details
    Browse the repository at this point in the history

  10. inline hashing and avx2 hax extraction

    @franziskuskiefer @W95Psp
    franziskuskiefer authored and W95Psp committed May 24, 2024
    Configuration menu
    Copy the full SHA
    ec4959c View commit details
    Browse the repository at this point in the history

  11. changes for F* extraction

    @franziskuskiefer @W95Psp
    franziskuskiefer authored and W95Psp committed May 24, 2024
    Configuration menu
    Copy the full SHA
    b46607b View commit details
    Browse the repository at this point in the history

  12. updated F*

    @franziskuskiefer @W95Psp
    franziskuskiefer authored and W95Psp committed May 24, 2024
    Configuration menu
    Copy the full SHA
    3239743 View commit details
    Browse the repository at this point in the history

  13. portable rejection sampling for neon for now

    @franziskuskiefer @W95Psp
    franziskuskiefer authored and W95Psp committed May 24, 2024
    Configuration menu
    Copy the full SHA
    aca1b2a View commit details
    Browse the repository at this point in the history

  14. feat(ci/F*): get rid of timestamps in patch files

    @W95Psp
    W95Psp committed May 24, 2024
    Configuration menu
    Copy the full SHA
    6f0495d View commit details
    Browse the repository at this point in the history

  15. chore(kyber/fstar): update patches following hacspec/hax#676

    @W95Psp
    W95Psp committed May 24, 2024
    Configuration menu
    Copy the full SHA
    4e777f8 View commit details
    Browse the repository at this point in the history

  16. Added scaffolding to get work started on ML-DSA. (#289)

    @xvzcf @W95Psp
    xvzcf authored and W95Psp committed May 24, 2024
    Configuration menu
    Copy the full SHA
    67618a4 View commit details
    Browse the repository at this point in the history

  17. wip

    @W95Psp
    W95Psp committed May 24, 2024
    Configuration menu
    Copy the full SHA
    6ca5766 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. fixup

    @franziskuskiefer
    franziskuskiefer committed May 26, 2024
    Configuration menu
    Copy the full SHA
    9226a0b View commit details
    Browse the repository at this point in the history

  2. actually inline neon/avx2

    @franziskuskiefer
    franziskuskiefer committed May 26, 2024
    Configuration menu
    Copy the full SHA
    4411d7f View commit details
    Browse the repository at this point in the history

  3. fixups and allow portable only extraction

    @franziskuskiefer
    franziskuskiefer committed May 26, 2024
    Configuration menu
    Copy the full SHA
    8738c18 View commit details
    Browse the repository at this point in the history

  4. fixup avx2

    @franziskuskiefer
    franziskuskiefer committed May 26, 2024
    Configuration menu
    Copy the full SHA
    4a445d0 View commit details
    Browse the repository at this point in the history

  5. fixup neon

    @franziskuskiefer
    franziskuskiefer committed May 26, 2024
    Configuration menu
    Copy the full SHA
    b13f986 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. fixups for avx2 extraction

    @franziskuskiefer
    franziskuskiefer committed May 27, 2024
    Configuration menu
    Copy the full SHA
    a84d517 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ml-kem-c-extraction-inlining-crates' of github.com:crys… 

    …pen/libcrux into ml-kem-c-extraction-inlining-crates
    @franziskuskiefer
    franziskuskiefer committed May 27, 2024
    Configuration menu
    Copy the full SHA
    e78b2d7 View commit details
    Browse the repository at this point in the history

  3. allow extracting everywhere

    @franziskuskiefer
    franziskuskiefer committed May 27, 2024
    Configuration menu
    Copy the full SHA
    0b6dd0f View commit details
    Browse the repository at this point in the history

  4. fixup c.sh

    @franziskuskiefer
    franziskuskiefer committed May 27, 2024
    Configuration menu
    Copy the full SHA
    66c2e55 View commit details
    Browse the repository at this point in the history

  5. add new config c2.yml

    @franziskuskiefer
    franziskuskiefer committed May 27, 2024
    Configuration menu
    Copy the full SHA
    03461b6 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. externalize intrinsics into a libcrux-intrinsics crate

    @W95Psp
    W95Psp committed May 28, 2024
    Configuration menu
    Copy the full SHA
    cd1de6b View commit details
    Browse the repository at this point in the history

  2. fixup neon; add new extraction (broken)

    @franziskuskiefer
    franziskuskiefer committed May 28, 2024
    Configuration menu
    Copy the full SHA
    d950056 View commit details
    Browse the repository at this point in the history

  3. update extraction

    @franziskuskiefer
    franziskuskiefer committed May 28, 2024
    Configuration menu
    Copy the full SHA
    6127191 View commit details
    Browse the repository at this point in the history

  4. externalize more intrinsics

    @W95Psp
    W95Psp committed May 28, 2024
    Configuration menu
    Copy the full SHA
    4c90f8e View commit details
    Browse the repository at this point in the history

  5. fix: assert_debug, expect 32, not 16

    @W95Psp
    W95Psp committed May 28, 2024
    Configuration menu
    Copy the full SHA
    2a53025 View commit details
    Browse the repository at this point in the history

  6. kill avx2/debug module

    @W95Psp
    W95Psp committed May 28, 2024
    Configuration menu
    Copy the full SHA
    40bb6e8 View commit details
    Browse the repository at this point in the history

  7. kill stale intrinsics modules

    @W95Psp
    W95Psp committed May 28, 2024
    Configuration menu
    Copy the full SHA
    1cbc9a7 View commit details
    Browse the repository at this point in the history

  8. check in c extractions

    @W95Psp
    W95Psp committed May 28, 2024
    Configuration menu
    Copy the full SHA
    15a7b29 View commit details
    Browse the repository at this point in the history

  9. Revert "check in c extractions" 

    This reverts commit 15a7b29.
    @W95Psp
    W95Psp committed May 28, 2024
    Configuration menu
    Copy the full SHA
    f75fee4 View commit details
    Browse the repository at this point in the history

  10. check in a snapshot of the c folder in c-snapshot

    @W95Psp
    W95Psp committed May 28, 2024
    Configuration menu
    Copy the full SHA
    c7724dd View commit details
    Browse the repository at this point in the history

  11. made sha3 safe

    @karthikbhargavan
    karthikbhargavan committed May 28, 2024
    Configuration menu
    Copy the full SHA
    3015d42 View commit details
    Browse the repository at this point in the history

  12. add a script for extracting c

    @W95Psp
    W95Psp committed May 28, 2024
    Configuration menu
    Copy the full SHA
    99909f5 View commit details
    Browse the repository at this point in the history

  13. work around eurydice issues in sha3

    @franziskuskiefer
    franziskuskiefer committed May 28, 2024
    Configuration menu
    Copy the full SHA
    49ca8f7 View commit details
    Browse the repository at this point in the history

  14. use config to extract

    @franziskuskiefer
    franziskuskiefer committed May 28, 2024
    Configuration menu
    Copy the full SHA
    c8a38e2 View commit details
    Browse the repository at this point in the history

  15. fixup sha3

    @franziskuskiefer
    franziskuskiefer committed May 28, 2024
    Configuration menu
    Copy the full SHA
    12fb7ff View commit details
    Browse the repository at this point in the history

  16. eurydice workaround

    @franziskuskiefer
    franziskuskiefer committed May 28, 2024
    Configuration menu
    Copy the full SHA
    e12075e View commit details
    Browse the repository at this point in the history

  17. A config to do separate bundling

    @msprotz
    msprotz committed May 28, 2024
    Configuration menu
    Copy the full SHA
    ed89380 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. testing one wrapper before going deeper

    @karthikbhargavan
    karthikbhargavan committed May 29, 2024
    Configuration menu
    Copy the full SHA
    fe31398 View commit details
    Browse the repository at this point in the history

  2. testing one wrapper before going deeper

    @karthikbhargavan
    karthikbhargavan committed May 29, 2024
    Configuration menu
    Copy the full SHA
    39e5d0d View commit details
    Browse the repository at this point in the history

  3. re-extract into c-snapshot/

    @W95Psp
    W95Psp committed May 29, 2024
    Configuration menu
    Copy the full SHA
    04843f2 View commit details
    Browse the repository at this point in the history

  4. c.yaml: replicate neon options for avx2

    @W95Psp
    W95Psp committed May 29, 2024
    Configuration menu
    Copy the full SHA
    540556f View commit details
    Browse the repository at this point in the history

  5. sha3 c.yaml

    @franziskuskiefer
    franziskuskiefer committed May 29, 2024
    Configuration menu
    Copy the full SHA
    7536322 View commit details
    Browse the repository at this point in the history

  6. Fix bundling

    @msprotz
    msprotz committed May 29, 2024
    Configuration menu
    Copy the full SHA
    88b6c42 View commit details
    Browse the repository at this point in the history

  7. c code sha3 with build

    @franziskuskiefer
    franziskuskiefer committed May 29, 2024
    Configuration menu
    Copy the full SHA
    c243e01 View commit details
    Browse the repository at this point in the history

  8. drop chunk

    @franziskuskiefer
    franziskuskiefer committed May 29, 2024
    Configuration menu
    Copy the full SHA
    8515d8b View commit details
    Browse the repository at this point in the history

  9. Dummies to make compilation work without hand edits

    @msprotz
    msprotz committed May 29, 2024
    Configuration menu
    Copy the full SHA
    3cc1486 View commit details
    Browse the repository at this point in the history

  10. missing intrinsics and functions

    @karthikbhargavan
    karthikbhargavan committed May 29, 2024
    Configuration menu
    Copy the full SHA
    38dd756 View commit details
    Browse the repository at this point in the history

  11. patch for intrinsics ordering

    @karthikbhargavan
    karthikbhargavan committed May 29, 2024
    Configuration menu
    Copy the full SHA
    cd9ad91 View commit details
    Browse the repository at this point in the history

  12. fixup build

    @franziskuskiefer
    franziskuskiefer committed May 29, 2024
    Configuration menu
    Copy the full SHA
    29e23ec View commit details
    Browse the repository at this point in the history

  13. add sha3 test

    @franziskuskiefer
    franziskuskiefer committed May 29, 2024
    Configuration menu
    Copy the full SHA
    49b7904 View commit details
    Browse the repository at this point in the history

  14. fix intrinsics

    @franziskuskiefer
    franziskuskiefer committed May 29, 2024
    Configuration menu
    Copy the full SHA
    9df56fd View commit details
    Browse the repository at this point in the history

  15. refresh

    @msprotz
    msprotz committed May 29, 2024
    Configuration menu
    Copy the full SHA
    165e74e View commit details
    Browse the repository at this point in the history

  16. refresh source

    @msprotz
    msprotz committed May 29, 2024
    Configuration menu
    Copy the full SHA
    798f69c View commit details
    Browse the repository at this point in the history

  17. And fix up the config for neon, too

    @msprotz
    msprotz committed May 29, 2024
    Configuration menu
    Copy the full SHA
    2c373e6 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Single run of Eurydice -- much easier

    @msprotz
    msprotz committed May 30, 2024
    Configuration menu
    Copy the full SHA
    ba2cbcb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'lucas/extract-intrinsics' of github.com:cryspen/libcrux… 

    … into lucas/extract-intrinsics
    @msprotz
    msprotz committed May 30, 2024
    Configuration menu
    Copy the full SHA
    1366394 View commit details
    Browse the repository at this point in the history

  3. WIP simplifying build

    @msprotz
    msprotz committed May 30, 2024
    Configuration menu
    Copy the full SHA
    98edcf1 View commit details
    Browse the repository at this point in the history

  4. Snapshot of the C code now lives in libcrux-ml-kem/c

    @msprotz
    msprotz committed May 30, 2024
    Configuration menu
    Copy the full SHA
    b015f6f View commit details
    Browse the repository at this point in the history

  5. Regenerate the code on AVX2... and update config so that AVX2 code-ge… 

    …n works too
    @msprotz
    msprotz committed May 30, 2024
    Configuration menu
    Copy the full SHA
    0382b43 View commit details
    Browse the repository at this point in the history

  6. Restore some config tweaks, reinstate the build of the sha3 test

    @msprotz
    msprotz committed May 30, 2024
    Configuration menu
    Copy the full SHA
    bc9b3ac View commit details
    Browse the repository at this point in the history

  7. Tweaks, good progress on whole mlkem compilation

    @msprotz
    msprotz committed May 30, 2024
    Configuration menu
    Copy the full SHA
    af4e0cf View commit details
    Browse the repository at this point in the history

  8. Work around AeneasVerif/eurydice#12

    @msprotz
    msprotz committed May 30, 2024
    Configuration menu
    Copy the full SHA
    a0b0b93 View commit details
    Browse the repository at this point in the history

  9. Use a two-dimensional array now that it's supported

    @msprotz
    msprotz committed May 30, 2024
    Configuration menu
    Copy the full SHA
    381a0a4 View commit details
    Browse the repository at this point in the history

  10. It compiles

    @msprotz
    msprotz committed May 30, 2024
    Configuration menu
    Copy the full SHA
    0ac31ce View commit details
    Browse the repository at this point in the history

  11. zomg

    @msprotz
    msprotz committed May 30, 2024
    Configuration menu
    Copy the full SHA
    d89558c View commit details
    Browse the repository at this point in the history

  12. updated C build and mlkem tests

    @franziskuskiefer
    franziskuskiefer committed May 30, 2024
    Configuration menu
    Copy the full SHA
    3b85af7 View commit details
    Browse the repository at this point in the history

  13. Regenerate the code with revised general-purpose slice index operation

    @msprotz
    msprotz committed May 30, 2024
    Configuration menu
    Copy the full SHA
    8b112db View commit details
    Browse the repository at this point in the history

  14. With loop unrolling

    @msprotz
    msprotz committed May 30, 2024
    Configuration menu
    Copy the full SHA
    34f92e1 View commit details
    Browse the repository at this point in the history

  15. benches

    @karthikbhargavan
    karthikbhargavan committed May 30, 2024
    Configuration menu
    Copy the full SHA
    5b5b73e View commit details
    Browse the repository at this point in the history

  16. bench

    @karthikbhargavan
    karthikbhargavan committed May 30, 2024
    Configuration menu
    Copy the full SHA
    08aee25 View commit details
    Browse the repository at this point in the history

  17. benches

    @karthikbhargavan
    karthikbhargavan committed May 30, 2024
    Configuration menu
    Copy the full SHA
    746f356 View commit details
    Browse the repository at this point in the history

  18. a snapshot of hand edits to speed up sha3

    @karthikbhargavan
    karthikbhargavan committed May 30, 2024
    Configuration menu
    Copy the full SHA
    87a5209 View commit details
    Browse the repository at this point in the history

  19. wip bundling

    @msprotz
    msprotz committed May 30, 2024
    Configuration menu
    Copy the full SHA
    8f297df View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Regenerated C code with fresh config

    @msprotz
    msprotz committed May 31, 2024
    Configuration menu
    Copy the full SHA
    5bc3ad6 View commit details
    Browse the repository at this point in the history

  2. Revised config

    @msprotz
    msprotz committed May 31, 2024
    Configuration menu
    Copy the full SHA
    4efb699 View commit details
    Browse the repository at this point in the history

  3. Refresh

    @msprotz
    msprotz committed May 31, 2024
    Configuration menu
    Copy the full SHA
    a91effc View commit details
    Browse the repository at this point in the history

  4. More small functions as static inline

    @msprotz
    msprotz committed May 31, 2024
    Configuration menu
    Copy the full SHA
    401a347 View commit details
    Browse the repository at this point in the history