Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract ML-KEM SIMD code to C #296

Merged
merged 99 commits into from
Jun 4, 2024
Merged

Extract ML-KEM SIMD code to C #296

merged 99 commits into from
Jun 4, 2024

Conversation

franziskuskiefer
Copy link
Member

@franziskuskiefer franziskuskiefer commented Jun 3, 2024 •
edited
Loading

We have working C code that is generally fast enought. There will be more changes needed but we'll track that as part of the integration processes.

The C code lives in libcrux-ml-kem/c now instead of hacl-packages because it is self-contained.

Follow-ups

Fixes #268

franziskuskiefer and others added 30 commits May 20, 2024 17:49
@franziskuskiefer
workarounds for charon
8c02e75
@franziskuskiefer
Merge branch 'dev' into franziskus/ml-kem-c-extraction
594ad84
@W95Psp
refactor: kill GenericOperations in favor of functions
9d0c481
@W95Psp
refactor: kill strings in unreachable
f85d218
@W95Psp
inlining
1dfd5d5
@W95Psp
kill two debug_asserts that cause trait issues in Charon
a2bc1fb
@W95Psp
commit C snapshot
3b3164c
@W95Psp
wip
2180172
@W95Psp
wip
d712003
@franziskuskiefer
update sha3 api to hide internal state
8511062
@franziskuskiefer @W95Psp
add dummy intrinsics file for extraction of avx2
886f965
@franziskuskiefer @W95Psp
F* extraction of poly-avx2
35d28a0
@franziskuskiefer @W95Psp
move neon hash functions into sha3 for ml-kem
5232b29
@franziskuskiefer @W95Psp
inline hashing and avx2 hax extraction
ec4959c
@franziskuskiefer @W95Psp
changes for F* extraction
b46607b
@franziskuskiefer @W95Psp
updated F*
3239743
@franziskuskiefer @W95Psp
portable rejection sampling for neon for now
aca1b2a
@W95Psp
feat(ci/F*): get rid of timestamps in patch files
6f0495d
@W95Psp
chore(kyber/fstar): update patches following hacspec/hax#676
4e777f8
@xvzcf @W95Psp
Added scaffolding to get work started on ML-DSA. (#289)
67618a4
@W95Psp
wip
6ca5766
@franziskuskiefer
fixup
9226a0b
@franziskuskiefer
actually inline neon/avx2
4411d7f
@franziskuskiefer
fixups and allow portable only extraction
8738c18
@franziskuskiefer
fixup avx2
4a445d0
@franziskuskiefer
fixup neon
b13f986
@franziskuskiefer
fixups for avx2 extraction
a84d517
@franziskuskiefer
Merge branch 'ml-kem-c-extraction-inlining-crates' of github.com:crys…
e78b2d7 
…pen/libcrux into ml-kem-c-extraction-inlining-crates
@franziskuskiefer
allow extracting everywhere
0b6dd0f
@franziskuskiefer
fixup c.sh
66c2e55
@franziskuskiefer franziskuskiefer mentioned this pull request Jun 3, 2024
Closed
2 tasks
@franziskuskiefer franziskuskiefer mentioned this pull request Jun 4, 2024
Merged
@franziskuskiefer franziskuskiefer merged commit 29f4d91 into dev Jun 4, 2024
38 checks passed
@franziskuskiefer franziskuskiefer deleted the franziskus/mlkem-c branch June 4, 2024 16:14
@franziskuskiefer franziskuskiefer mentioned this pull request Jun 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikbhargavan karthikbhargavan Awaiting requested review from karthikbhargavan

Assignees
No one assigned
Labels
None yet
Projects
libcrux
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@franziskuskiefer @W95Psp @xvzcf @karthikbhargavan @msprotz