Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML-DSA: Signing works across all parameter sets. #320

Merged
merged 12 commits into from
Jun 19, 2024

Conversation

xvzcf
Copy link
Contributor

@xvzcf xvzcf commented Jun 17, 2024

  • The contents of the two files serialize.rs and deserialize.rs have been moved into a module called encoding, serialization and deserialization functions are now grouped together according to what they act upon.
  • The KATs have been updating to also store a signing_randomness value that is used during signing
  • I now use tuple structs to hold the signing key, verification key, and signature, as well as another struct that groups the signing and verification key tuple structs

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a few nits

libcrux-ml-dsa/src/arithmetic.rs Show resolved Hide resolved
libcrux-ml-dsa/src/arithmetic.rs Outdated Show resolved Hide resolved
libcrux-ml-dsa/src/arithmetic.rs Outdated Show resolved Hide resolved
libcrux-ml-dsa/src/encoding/error.rs Outdated Show resolved Hide resolved
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@franziskuskiefer franziskuskiefer merged commit 0cabdb4 into dev Jun 19, 2024
47 of 48 checks passed
@franziskuskiefer franziskuskiefer deleted the goutam/ml-dsa-signing branch June 19, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants