Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize kyber key generation #37

Merged
merged 6 commits into from
Aug 9, 2023
Merged

Optimize kyber key generation #37

merged 6 commits into from
Aug 9, 2023

Conversation

xvzcf
Copy link
Contributor

@xvzcf xvzcf commented Aug 8, 2023

No description provided.

@xvzcf xvzcf changed the title Optimize kyber Optimize kyber key generation Aug 8, 2023
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements already.
Some comments and a few things that might get us another couple easy microseconds.

src/kem/kyber768/ind_cpa.rs Outdated Show resolved Hide resolved
src/kem/kyber768/ntt.rs Show resolved Hide resolved
src/kem/kyber768/sampling.rs Outdated Show resolved Hide resolved
src/kem/kyber768/sampling.rs Outdated Show resolved Hide resolved
src/kem/kyber768/serialize.rs Outdated Show resolved Hide resolved
src/kem/kyber768/serialize.rs Outdated Show resolved Hide resolved
@franziskuskiefer franziskuskiefer marked this pull request as ready for review August 9, 2023 17:30
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's get this in

src/kem/kyber768/utils/field.rs Show resolved Hide resolved
@franziskuskiefer franziskuskiefer enabled auto-merge (squash) August 9, 2023 17:34
@franziskuskiefer franziskuskiefer merged commit b4214ed into dev Aug 9, 2023
6 checks passed
@franziskuskiefer franziskuskiefer deleted the optimize-kyber branch August 9, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants