Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reworking field operations. #38

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Reworking field operations. #38

merged 3 commits into from
Aug 10, 2023

Conversation

xvzcf
Copy link
Contributor

@xvzcf xvzcf commented Aug 9, 2023 •
edited
Loading

I added some code for barrett reduction, and tried to remove spurious modulo operations whereever I could.

franziskuskiefer
franziskuskiefer requested changes Aug 10, 2023
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Two comments. One to address in this PR and the other one we can discuss later and do in the next one if we decide to do it.

src/kem/kyber768/field_element.rs Outdated Show resolved Hide resolved
src/kem/kyber768/field_element.rs Show resolved Hide resolved
@franziskuskiefer franziskuskiefer merged commit ce1ef46 into dev Aug 10, 2023
6 checks passed
@franziskuskiefer franziskuskiefer deleted the kyber-field-ops branch August 10, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xvzcf @franziskuskiefer