-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making serialization functions specific instead of generic and removing helper code. #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I left a few comments for some more improvements. If you want to push some of them into followups, just mark them as such.
Please run rustfmt on all the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
I'm approving but please add some comments. When the comments are resolved you can merge it.
serialize
anddeserialize
functions that take in the number of bits to use as a parameter, and replaced them by specific functions that work on 1, 4, 10, and 12 bits only