Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use montgomery multiplication everywhere. #49

Merged
merged 6 commits into from
Aug 22, 2023
Merged

Use montgomery multiplication everywhere. #49

merged 6 commits into from
Aug 22, 2023

Conversation

xvzcf
Copy link
Contributor

@xvzcf xvzcf commented Aug 22, 2023

No description provided.

franziskuskiefer
franziskuskiefer approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

On my machine I see the following

  • Key generation is ~7% slower (32µs vs 30.5µs)
  • encaps is significantly slower (68µs vs 38µs)
  • decaps is significantly faster 🎉 (35µs vs 43µs)

@xvzcf xvzcf merged commit dc08ab4 into dev Aug 22, 2023
6 checks passed
@xvzcf xvzcf deleted the montgomery-reduction branch August 22, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
libcrux
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xvzcf @franziskuskiefer