Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Kyber ref for F-star proofs #99

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Refactoring Kyber ref for F-star proofs #99

merged 2 commits into from
Sep 29, 2023

Conversation

xvzcf
Copy link
Contributor

@xvzcf xvzcf commented Sep 28, 2023

Make compress::compress_q in the reference code look more like compress::compress_d in the specification.

Copy link
Contributor

@karthikbhargavan karthikbhargavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks more explicit and will help proofs in short-run, but we don't have to do it this way just to make the proofs work. If you preferred the earlier code that would be fine too, this just makes it a 1-1 correspondence, which is more convenient.

@xvzcf
Copy link
Contributor Author

xvzcf commented Sep 28, 2023

This looks more explicit and will help proofs in short-run, but we don't have to do it this way just to make the proofs work. If you preferred the earlier code that would be fine too, this just makes it a 1-1 correspondence, which is more convenient.

I think the change makes the code look nicer anyway, what do you think @franziskuskiefer?

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change makes the code look nicer anyway, what do you think @franziskuskiefer?

Yeah this looks nice, lets keep it.

@xvzcf xvzcf merged commit 2d41bdc into dev Sep 29, 2023
10 checks passed
@xvzcf xvzcf deleted the kyber-ref-refactoring branch September 29, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants