Skip to content

Commit

Permalink
Initial windows support: samueleaton#68
Browse files Browse the repository at this point in the history
1. Use process.terminate instead of signal(:kill)
2. Terminate app process before rebuilding on Windows
  • Loading branch information
zw963 committed Dec 6, 2024
1 parent 0566a5d commit 50065d1
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion src/sentry/process_runner.cr
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,14 @@ module Sentry
private def build_app_process : Process::Status
stdout "🤖 compiling #{@display_name}..."

{% if flag?(:win32) %}
if (app_process = @app_process).is_a? Process
stdout "🤖 killing #{@display_name}..."
app_process.terminate
# app_process.wait
end
{% end %}

Process.run(
@build_command,
@build_args_list,
Expand All @@ -151,7 +159,7 @@ module Sentry
if (app_process = @app_process).is_a? Process
unless app_process.terminated?
stdout "🤖 killing #{@display_name}..."
app_process.signal(:kill)
app_process.terminate
app_process.wait
end
end
Expand Down

0 comments on commit 50065d1

Please sign in to comment.