[CI] Filter runs of Smoke Test workflow #15457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workflow now only triggers on changes to paths that are related to platform-specific code. It also runs on a nightly schedule and can be triggered manually.
Sija
reviewed
Feb 12, 2025
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
ysbaddaden
reviewed
Feb 12, 2025
.github/workflows/smoke.yml
Outdated
| on: | ||
| push: | ||
| paths: | ||
| - 'src/lib_c/*{bsd,i386,android,solaris,dragonfly}*/**' |
There was a problem hiding this comment.
suggestion: if we touch any libc bindings for Linux or mac for 3xample, it might affect compilation of other targets (e.g. missing)?
There was a problem hiding this comment.
I had been wondering about this restriction as well. It won't hurt to loosen it. Makes everything a bit simpler. And we're not much chaning lib bindings on any target anyway.
ysbaddaden
approved these changes
Feb 12, 2025
ysbaddaden
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow now only triggers on changes to paths that are related to platform-specific code.
It also runs on a nightly schedule and can be triggered manually.
Part of #14983