Improve docs for Channel#close
#15910
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Johannes Müller <[email protected]>
straight-shoota
approved these changes
Jun 17, 2025
Sija
reviewed
Jun 18, 2025
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
straight-shoota
changed the title
Channel#close
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve
Channel#closedocumentation to clarify the expected behavior when aBufferedChannelgets closed when there are buffered values pending to be consumedI'm not super happy with the "If the channel has buffered values.." wording, but I'm pushing it as a starting point for discussing a better one 🙂