Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 7 speedy pushes #13

Merged
merged 15 commits into from
Oct 4, 2023
Merged

[WIP] 7 speedy pushes #13

merged 15 commits into from
Oct 4, 2023

Conversation

bohendo
Copy link
Collaborator

@bohendo bohendo commented Sep 29, 2023

resolves #7
resolves #6

Currently broken: the zipped input file gets corrupted upon being uploaded to the S3-style DigitalOcean bucket.
Fixed, all is working as expected now

Summary by CodeRabbit

  • New Feature: Added "init" command to the CLI tool for creating a new cloudexec.toml launch configuration file in the current directory.
  • Improvement: Enhanced the UploadDirectoryToSpaces function to create a zipped archive of the source directory and upload it to a DigitalOcean bucket, including handling symbolic links and creating directories in the archive.
  • Improvement: Updated the cleanup process after job execution to check for output files and error logs before attempting to upload them to the S3 bucket.
  • Improvement: Modified the code to download an input archive instead of a directory and unzip it.
  • Chore: Updated the version of coderabbitai/ai-pr-reviewer action to v1.16.2.

@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Image description CodeRabbit

Walkthrough

This update enhances the cloudexec CLI tool with a new "init" command, improves directory upload functionality to DigitalOcean Spaces, and refines job execution cleanup. It also updates the AI PR reviewer action version and modifies .gitignore.

Changes

Files Summary
.github/workflows/lint.yml Updated the version of coderabbitai/ai-pr-reviewer action to v1.16.2.
.gitignore Added example/input.zip file and removed .vscode directory.
cmd/cloudexec/launch.go, cmd/cloudexec/main.go Introduced a new "init" command in the CLI tool that creates a cloudexec.toml launch configuration file.
cmd/cloudexec/push.go, cmd/cloudexec/user_data.sh.tmpl, pkg/s3/s3.go Enhanced the UploadDirectoryToSpaces function to create a zipped archive of the source directory and upload it to a DigitalOcean bucket. Improved job execution cleanup by checking for output files and error logs before uploading them.

🐇💻

In the land of code, where the brackets lie,

A rabbit hopped, tweaking functions on the fly.

With a zip and a push, an 'init' command so neat,

Our cloud exec tool now feels complete.

So here's to the changes, big and small,

May our code run smooth, and never fall! 🎉🥕


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 5734037 and 3bab59f commits.
Files selected (5)
  • .gitignore (1)
  • cmd/cloudexec/launch.go (2)
  • cmd/cloudexec/push.go (1)
  • cmd/cloudexec/user_data.sh.tmpl (3)
  • pkg/s3/s3.go (2)
Files ignored due to filter (1)
  • example/input/archive.zip
Files not summarized due to errors (5)
  • .gitignore (nothing obtained from openai)
  • pkg/s3/s3.go (nothing obtained from openai)
  • cmd/cloudexec/user_data.sh.tmpl (nothing obtained from openai)
  • cmd/cloudexec/launch.go (nothing obtained from openai)
  • cmd/cloudexec/push.go (nothing obtained from openai)
Files not reviewed due to errors (5)
  • pkg/s3/s3.go (no response)
  • .gitignore (no response)
  • cmd/cloudexec/user_data.sh.tmpl (no response)
  • cmd/cloudexec/launch.go (no response)
  • cmd/cloudexec/push.go (no response)
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 3bab59f and 43eb0fd commits.
Files selected (3)
  • cmd/cloudexec/main.go (2)
  • cmd/cloudexec/push.go (1)
  • cmd/cloudexec/user_data.sh.tmpl (3)
Files not summarized due to errors (3)
  • cmd/cloudexec/push.go (nothing obtained from openai)
  • cmd/cloudexec/user_data.sh.tmpl (nothing obtained from openai)
  • cmd/cloudexec/main.go (nothing obtained from openai)
Files not reviewed due to errors (3)
  • cmd/cloudexec/main.go (no response)
  • cmd/cloudexec/user_data.sh.tmpl (no response)
  • cmd/cloudexec/push.go (no response)
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 43eb0fd and bbd58bd commits.
Files selected (1)
  • .github/workflows/lint.yml (1)
Files not summarized due to errors (1)
  • .github/workflows/lint.yml (nothing obtained from openai)
Files not reviewed due to errors (1)
  • .github/workflows/lint.yml (no response)
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 5734037 and bbd58bd commits.
Files selected (7)
  • .github/workflows/lint.yml (1)
  • .gitignore (1)
  • cmd/cloudexec/launch.go (2)
  • cmd/cloudexec/main.go (2)
  • cmd/cloudexec/push.go (1)
  • cmd/cloudexec/user_data.sh.tmpl (3)
  • pkg/s3/s3.go (2)
Files not summarized due to errors (7)
  • .gitignore (nothing obtained from openai)
  • cmd/cloudexec/user_data.sh.tmpl (nothing obtained from openai)
  • cmd/cloudexec/main.go (nothing obtained from openai)
  • .github/workflows/lint.yml (nothing obtained from openai)
  • cmd/cloudexec/launch.go (nothing obtained from openai)
  • cmd/cloudexec/push.go (nothing obtained from openai)
  • pkg/s3/s3.go (nothing obtained from openai)
Files not reviewed due to errors (7)
  • .github/workflows/lint.yml (no response)
  • cmd/cloudexec/main.go (no response)
  • cmd/cloudexec/user_data.sh.tmpl (no response)
  • cmd/cloudexec/push.go (no response)
  • .gitignore (no response)
  • cmd/cloudexec/launch.go (no response)
  • pkg/s3/s3.go (no response)
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 5734037 and bbd58bd commits.
Files selected (7)
  • .github/workflows/lint.yml (1)
  • .gitignore (1)
  • cmd/cloudexec/launch.go (2)
  • cmd/cloudexec/main.go (2)
  • cmd/cloudexec/push.go (1)
  • cmd/cloudexec/user_data.sh.tmpl (3)
  • pkg/s3/s3.go (2)
Files skipped from review due to trivial changes (6)
  • .github/workflows/lint.yml
  • .gitignore
  • cmd/cloudexec/launch.go
  • cmd/cloudexec/main.go
  • cmd/cloudexec/user_data.sh.tmpl
  • pkg/s3/s3.go
Review comments generated (7)
  • Review: 6
  • LGTM: 1

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

cmd/cloudexec/push.go Outdated Show resolved Hide resolved
cmd/cloudexec/push.go Outdated Show resolved Hide resolved
cmd/cloudexec/push.go Outdated Show resolved Hide resolved
cmd/cloudexec/push.go Outdated Show resolved Hide resolved
cmd/cloudexec/push.go Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between bbd58bd and 2dff1e2 commits.
Files selected (1)
  • cmd/cloudexec/push.go (1)
Review comments generated (2)
  • Review: 2
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

cmd/cloudexec/push.go Outdated Show resolved Hide resolved
cmd/cloudexec/push.go Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 2dff1e2 and 9d4c645 commits.
Files selected (1)
  • cmd/cloudexec/push.go (1)
Review comments generated (3)
  • Review: 2
  • LGTM: 1

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

cmd/cloudexec/push.go Outdated Show resolved Hide resolved
cmd/cloudexec/push.go Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 9d4c645 and 64cf848 commits.
Files selected (1)
  • cmd/cloudexec/push.go (1)
Review comments generated (1)
  • Review: 1
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

cmd/cloudexec/push.go Show resolved Hide resolved
@bohendo bohendo merged commit 49d7ed8 into main Oct 4, 2023
@bohendo bohendo deleted the 7-speedy-pushes branch October 4, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallelize pushes/pulls Handle upload of directory links
1 participant