Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre release #17

Merged
merged 11 commits into from
Oct 6, 2023
Merged

Pre release #17

merged 11 commits into from
Oct 6, 2023

Conversation

bohendo
Copy link
Collaborator

@bohendo bohendo commented Oct 6, 2023

Inject version, git commit, and build time info into the cloudexec version command in preparation for a tagged release.

Summary by CodeRabbit

  • New Feature: Enhanced cloudexec version command to display version, git commit, and build time information. This provides users with more detailed context about the build they are using.
  • Bug Fix: Improved error messages in configure.go. Now, when processing a 1password reference fails, the error message will include stderr output for better issue diagnosis.
  • Chore: Updated .gitignore to ignore *.backup files, helping to keep the repository clean from temporary or backup files.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Image description CodeRabbit

Walkthrough

This pull request introduces enhancements to the cloudexec project. It improves error messaging, refactors variable names for better visibility, and injects build-time information into the cloudexec version command. The changes span across several files including Go source files, Makefile, flake.nix, and .goreleaser.yml.

Changes

File(s) Summary
.gitignore Added a new file pattern *.backup to be ignored.
cmd/cloudexec/configure.go Improved the error message returned when processing a 1password reference fails.
cmd/cloudexec/main.go Refactored variable names from version, commit, date, configFilePath, and launchConfigFilePath to Version, Commit, Date, ConfigFilePath, and LaunchConfigFilePath.
Makefile, flake.nix, .goreleaser.yml Added functionality to inject version, git commit, and build time information into the cloudexec version command.

"In the land of code, where logic is king,
A rabbit hopped by, making variables sing.
With a twinkle in his eye and a skip in his hop,
He improved our messages, oh what a swap! 🐇💻
Now with each build, we'll know more,
Version, commit, date, oh what's in store!
So here's to the rabbit, with his code so neat,
Making cloudexec's journey even more sweet!" 🎉🥕


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between bb00055 and ddc6ce1 commits.
Files selected (5)
  • .gitignore (1)
  • Makefile (2)
  • cmd/cloudexec/configure.go (1)
  • cmd/cloudexec/main.go (4)
  • flake.nix (1)
Files skipped from review due to trivial changes (3)
  • .gitignore
  • cmd/cloudexec/configure.go
  • cmd/cloudexec/main.go
Review comments generated (4)
  • Review: 2
  • LGTM: 2

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Makefile Outdated Show resolved Hide resolved
flake.nix Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between ddc6ce1 and db14f69 commits.
Files selected (2)
  • .goreleaser.yml (1)
  • Makefile (2)
Files skipped from review due to trivial changes (1)
  • .goreleaser.yml
Review comments generated (2)
  • Review: 1
  • LGTM: 1

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Makefile Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between db14f69 and 9c5ed69 commits.
Files selected (1)
  • Makefile (2)
Review comments generated (3)
  • Review: 2
  • LGTM: 1

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
@bohendo bohendo merged commit 50d1c8c into main Oct 6, 2023
@bohendo bohendo deleted the pre-release branch October 6, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant