Raise exception when compiler version is not supported by solc-select #234
Conversation
0xalpharush
force-pushed
the
check-solc-select-support
branch
from
1ca8698 to
4c8bafd
Compare
0xalpharush
force-pushed
the
check-solc-select-support
branch
from
4c8bafd to
bee5969
Compare
0xalpharush
force-pushed
the
check-solc-select-support
branch
from
bee5969 to
136a0ce
Compare
| if self.version not in solc_select.installed_versions(): | ||
| if ( | ||
| self.version not in solc_select.installed_versions() | ||
| and self.version in solc_select.get_available_versions() |
There was a problem hiding this comment.
get_available_versions makes an url query. install_artifacts calls also get_available_versions, so here we end up making two time the same URL query, which is not great.
Maybe we can rather update solc-select to return boolean in install_artifacts to indicate success?
There was a problem hiding this comment.
Looks like install_artifacts returns True on success as of this PR to solc-select and, as before, throws on failure. Given the throw on failure, we could try/catch the install_artifacts call instead of using an if statement to save the extra url query.
There was a problem hiding this comment.
I think that was an oversight. We should return false crytic/solc-select#143. I also opened issues to cache these requests crytic/solc-select#145.
Currently, when an unsupported version of solc is used for the Etherscan platform an invalid compilation error is raised. It would be helpful to indicate that solc-select does not some solc versions. It does raise an argparse error so it's clear when using from the command line. Since we're calling an internal solc-select API, I figure crytic-compile should do the error handling/ validation.