Foundry --skip test script by default
#466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
0xalpharush
reviewed
Jul 5, 2023
crytic_compile/platform/foundry.py
Outdated
Comment on lines
63
to
64
| "test", | ||
| "script", |
There was a problem hiding this comment.
Suggested change
| "test", | |
| "script", | |
| "'*/test/**'", | |
| "'*/script/**'", | |
| "--force", |
This is necessary because not all test and scripts follow the foundry naming convention and if there's test/script artifacts in the cache they need to be removed
There was a problem hiding this comment.
I have tested like this, but strangely, it was not working correctly (not skipping), if you wrap it with single quotes. At the same time, If I copy-paste the output from logs, forge build --build-info --skip '*/test/**' '*/script/**' --force and run it, that is working. (No idea, if it is a python/OS issue)
Then I tried without quotes (seems like the forge supports this), and it worked.
|
this was replaced by #488 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #435
I tried to see if I could fix this quickly, and it seems to work.
Let me know if you would like to fix the naming or how the flag should behave, I can work on that