Add unique non-zero exit code for failing tests #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e up errors with exit codes from cmd, organized exit code definitions into one package
anishnaik
approved these changes
Feb 26, 2024
Leeyah-123
pushed a commit
to Leeyah-123/medusa
that referenced
this pull request
Jun 4, 2024
…e up errors with exit codes from cmd, organized exit code definitions into one package (crytic#301) Co-authored-by: anishnaik <[email protected]>
s4nsec
pushed a commit
that referenced
this pull request
Jul 9, 2024
…e up errors with exit codes from cmd, organized exit code definitions into one package (#301) Co-authored-by: anishnaik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #289. It organizes exit code definitions into
cmd/exitcodes/, adds a unique exit code for failed tests during afuzzrun, and adds a generic way to bubble up errors with exit codes fromcmdtomain.go.Exit codes: 0 = success, 1 = general error, 7 = failed test.
Any future exit codes we add would be >7. I left a few as a gap since some errors (0-5) are more standard for other use cases on some platforms.