Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install artifacts never returns false #143

Closed
0xalpharush opened this issue Jan 3, 2023 · 4 comments
Closed

install artifacts never returns false #143

0xalpharush opened this issue Jan 3, 2023 · 4 comments
Labels
good first issue Good for newcomers

Comments

@0xalpharush
Copy link
Contributor

def install_artifacts(versions: [str]) -> bool:

@azpwnz
Copy link
Contributor

azpwnz commented Jan 23, 2023

Hi @0xalpharush ,
I would love to contribute to the repo.

Could you suggest in which cases install_artifacts should return False?
Would appreciate any details.

Thank you! :)

@0xalpharush
Copy link
Contributor Author

@azpwnz It should return False when installation of versions are unsuccessful. That is, when get_available_versions does not contain all of the versions.

@azpwnz
Copy link
Contributor

azpwnz commented Jan 29, 2023

@0xalpharush thank you for the explanation!
I've prepared a PR with the changes #151

@elopez
Copy link
Member

elopez commented Dec 31, 2024

Closing as this has been released in v1.0.4. Thanks for the contribution @azpwnz !

@elopez elopez closed this as completed Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants