Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional error handling on being unable to access github #80

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

0xicingdeath
Copy link

@0xicingdeath 0xicingdeath commented Dec 1, 2021

Scenarios:

  1. If GitHub is unreachable, the earliest_release should be 0.4.10 instead of 0.4.0.
  2. If soliditylang is unreachable, an error should be raised
  3. If a user installs all, then all binaries from soliditylang will be installed, with a warning message that 0.4.0-0.4.9 are unavailable
  4. If a user tries to fetch available versions and GitHub is unreachable, solc-select will continue execution, with a warning message that 0.4.0-0.4.9 are unavailable

Setting this to a draft PR, so we have time to think about how to test.

@0xicingdeath 0xicingdeath marked this pull request as draft December 1, 2021 19:15
@antonper
Copy link

antonper commented Nov 1, 2022

In current version also valid_version always tries to query latestRelease. It would be nice if in case github is not accessible the latest version check will not fail.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Natalie Chin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants