intro-comparch/rotations: Change rotations parameter type

Functions of the rotation task accepted `int` parameters, which can lead to unexpected behavior with bit operators. For more details, see systems-cs-pub-ro/iocla#171. Signed-off-by: Cosmin Popa <[email protected]>
cs-pub-ro · Mar 19, 2024 · c18c1b9 · c18c1b9
1 parent 10fcfcf
commit c18c1b9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/chapters/intro-computer-architecture/binary-hex/drills/tasks/rotations/solution/rotations.c b/chapters/intro-computer-architecture/binary-hex/drills/tasks/rotations/solution/rotations.c
@@ -2,7 +2,7 @@
 
 #include <stdio.h>
 
-void rotate_left(int *number, int bits)
+void rotate_left(unsigned int *number, int bits)
 {
 	unsigned int bit_mask = -1;
 
@@ -13,7 +13,7 @@ void rotate_left(int *number, int bits)
 	(*number) |= bit_mask;
 }
 
-void rotate_right(int *number, int bits)
+void rotate_right(unsigned int *number, int bits)
 {
 	unsigned int bit_mask = -1;
 
@@ -26,7 +26,7 @@ void rotate_right(int *number, int bits)
 
 int main(void)
 {
-	int number;
+	unsigned int number;
 
 	number = 0x80000000;
 	rotate_left(&number, 1);

diff --git a/chapters/intro-computer-architecture/binary-hex/drills/tasks/rotations/support/rotations.c b/chapters/intro-computer-architecture/binary-hex/drills/tasks/rotations/support/rotations.c
@@ -2,14 +2,14 @@
 
 #include <stdio.h>
 
-void rotate_left(int *number, int bits)
+void rotate_left(unsigned int *number, int bits)
 {
 	/* TODO */
 	(void) number;
 	(void) bits;
 }
 
-void rotate_right(int *number, int bits)
+void rotate_right(unsigned int *number, int bits)
 {
 	/* TODO */
 	(void) number;