Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lab 7 checkers #129

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Add lab 7 checkers #129

merged 1 commit into from
Nov 12, 2024

Conversation

LauraRuse
Copy link

Prerequisite Checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Updated relevant documentation (if needed).

Description of changes

Add checkers for lab 7 tasks.

@LauraRuse LauraRuse force-pushed the Lab7checkers branch 3 times, most recently from 4ee0eea to 2817b79 Compare November 10, 2024 14:18
@github-actions github-actions bot added area/tasks Update to tasks topic/compute Related to "Compute" chapter kind/new New content / item labels Nov 11, 2024
@teodutu teodutu added the needs-rendering The PR makes changes to the website that need to be rendered label Nov 11, 2024
Copy link

Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checker is great. Now update the task's README.md to specify that students need to run make skels to generate the support/ folder and then add a sample run of the checker script with all tests passing so students know what to look for.

Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is alright now. Just rebase the main branch to remove the merge conflict and then wait for @NickZaharia308' review.

Copy link

@NickZaharia308 NickZaharia308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After fixing the readme, this can be merged. 👍

Add checkers for lab 7 tasks.

Signed-off-by: Laura Ruse <[email protected]>
@teodutu teodutu merged commit 5e4424b into cs-pub-ro:main Nov 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tasks Update to tasks kind/new New content / item needs-rendering The PR makes changes to the website that need to be rendered topic/compute Related to "Compute" chapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants