-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IO to OpenEducation methodology #75
Conversation
a351b9b
to
d84d43a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check my comments to see some easy first fixes and also why the build fails. Then when it passes I'll make a more in-depth review.
- Move the task descriptions from the
reading/
files to each task'sREADME.md
- Remove references to the common makefiles (
.../common/makefile/*.mk
). Copy their content to each makefile that includes them so the tasks don't depend on outside resources.
chapters/io/client-server-model/drills/tasks/client-server/README.md
Outdated
Show resolved
Hide resolved
chapters/io/io-internals/drills/tasks/buffering/support/libc_buffering.c
Outdated
Show resolved
Hide resolved
chapters/io/io-internals/drills/tasks/buffering/support/printf_buffering.c
Outdated
Show resolved
Hide resolved
chapters/io/io-internals/drills/tasks/buffering/support/no_buffering.c
Outdated
Show resolved
Hide resolved
chapters/io/local-io-in-action/drills/tasks/simple-file-operations/support/Makefile
Outdated
Show resolved
Hide resolved
chapters/io/pipes/drills/tasks/receive-challenges/support/Makefile
Outdated
Show resolved
Hide resolved
d84d43a
to
18a5278
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build fails because chapters/io/arena/drills/tasks/mini-shell/
is missing its support/
folder which causes the Makefile symlink to point to an invalid path.
chapters/io/file-mappings/drills/tasks/file-mappings/support/benchmark_cp.sh
Outdated
Show resolved
Hide resolved
chapters/io/remote-io/drills/tasks/receive-challenges/support/Makefile
Outdated
Show resolved
Hide resolved
chapters/io/remote-io/drills/tasks/send-receive/support/receiver.py
Outdated
Show resolved
Hide resolved
18a5278
to
d5907ce
Compare
Published at https://cs-pub-ro.github.io/operating-systems/75/ |
@razvand, since I also made changes to the content itself, I think you should also review this. |
5fd9558
to
7e8cb71
Compare
Show links that do not match expected patterns after solving references. Signed-off-by: Alex Apostolescu <[email protected]>
531f0a8
to
b84d30e
Compare
Generic stuff such as removing
|
b84d30e
to
b9f6374
Compare
b9f6374
to
27030fa
Compare
I think you forgot to add a file or messed up its name: https://github.com/cs-pub-ro/operating-systems/actions/runs/12047113855/job/33588983238#step:6:227 |
27030fa
to
b9b50d3
Compare
I have no idea what happened - seems like the |
Published at https://cs-pub-ro.github.io/operating-systems/75/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The slides are still empty [1] because you forgot to add the slides/
folders in each subchapter.
b9b50d3
to
d4d42ef
Compare
It was a subtle metaphor for the need of I/O. Anyway, check again. |
d4d42ef
to
e66f8d0
Compare
Published at https://cs-pub-ro.github.io/operating-systems/75/ |
This commit restructures the IO chapter according to OpenEdu methodology. This comprises of: - refactoring and changing the order of chapters - generating support files from solution - breaking arena into smaller sections - fixing Makefiles from tasks to be self-contained Signed-off-by: Mihnea Firoiu <[email protected]> Signed-off-by: Alex Apostolescu <[email protected]>
e66f8d0
to
e926128
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fuck that Java error.
Prerequisite Checklist
Description of changes
Align the IO course to the OpenEdu methodology.
Change the content of laboratories and change the "storyline" to:
Besides these, in
quides/
you can find adjacent topics not mandatory to finish the labs, such asfile-descriptor table and open file table
,file-mappings
,kernel caching
, andsendfile benchmarking
.