Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace str* with os_str* #97

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Replace str* with os_str* #97

merged 1 commit into from
Oct 14, 2024

Conversation

mucel29
Copy link

@mucel29 mucel29 commented Oct 14, 2024

Prerequisite Checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Updated relevant documentation (if needed).

Description of changes

@mariapana mariapana self-requested a review October 14, 2024 08:19
mariapana
mariapana approved these changes Oct 14, 2024
View reviewed changes
Copy link

@mariapana mariapana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@edi33416
Copy link

@mucel29 checkpatch is failing

@mariapana mariapana merged commit cbbc7b9 into cs-pub-ro:main Oct 14, 2024
2 of 3 checks passed
@edi33416
Copy link

@mucel29 nothing to do now, since it was merged.

@mucel29 mucel29 deleted the fix-string branch November 4, 2024 06:51
@teodutu teodutu added the student-contrib Fix or improvement made by a student label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariapana mariapana mariapana approved these changes

Assignees
No one assigned
Labels
student-contrib Fix or improvement made by a student
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mucel29 @edi33416 @mariapana @teodutu