respect grpc service transport #4744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
force-pushed
the
respect-service-transport
branch
from
4928b96
to
39a7a48
Compare
This was referenced Jun 27, 2024
butonic
force-pushed
the
respect-service-transport
branch
2 times, most recently
from
c7462f7
to
13c88ef
Compare
|
hm ... looking at kuberesolver I don't fully grok how it reconnects the watcher: sercand/kuberesolver#53 |
kobergj
requested changes
Jul 30, 2024
kobergj
approved these changes
Jul 30, 2024
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Co-authored-by: kobergj <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
respect-service-transport
branch
from
856d4c3
to
f41db26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service registry now takes into account the service transport when creating grpc clients. This allows using
dnsandunixas the protocol in addition totcp.dnswill turn the gRPC client into a Thick Client that can look up multiple endpoints via DNS. Furthermore, we enabled round robin load balancing for the default transparent retry configuration of gRPC.related: