Allow to disable backrest container #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AKamyshnikova
force-pushed
the
disable-baskrest
branch
from
4866aac to
41d6394
Compare
AKamyshnikova
force-pushed
the
disable-baskrest
branch
2 times, most recently
from
3ef66c6 to
fd96920
Compare
Add enabled field for BackRestSidecar spec. By default enabled is true (original behaviour). Setting to false will drop back-rest container deployment.
AKamyshnikova
force-pushed
the
disable-baskrest
branch
from
b29b31d to
282ba56
Compare
|
@cscetbon Could you take a look? |
cscetbon
reviewed
Nov 29, 2023
| - id: lower-repo | ||
| shell: pwsh | ||
| run: | | ||
| "::set-output name=repository::$($env:GITHUB_REPOSITORY.ToLowerInvariant())" |
There was a problem hiding this comment.
Why not just use github.event.repository.name ?
There was a problem hiding this comment.
It will give an error if the repository name has some uppercase letters (exactly what AKamyshnikova has).
The is a discussion here https://github.com/orgs/community/discussions/10553 and I used one of the suggested options to workaround this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add enabled field for BackRestSidecar spec.
By default enabled is true (original behaviour).
Setting to false will drop back-rest container deployment.
Why?
If out of box backup/restore tool is used - deploy of back-rest container is not necessary.
Checklist