Added monospace code font #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to GeekyAnts/nativebase-templates#19, From iOS 15 onward, we need "Courier New" instead of "Courier". I also think making it bold with "Courier New" is better.
|
waynew99
requested changes
May 1, 2022
components/Code/Code.tsx
Outdated
| Hack: require("../../assets/fonts/Hack-Regular.ttf"), | ||
| }); | ||
|
|
||
| const courierFont = Platform.Version >= 15 ? 'Courier New' : 'Courier'; |
There was a problem hiding this comment.
I just tested on iOS. It seems like Platform.Version returns a string on Android and a number on iOS, which typescript complains about. And we can get the major version number from Platform.Version:
const courierFont = (Platform.OS === "ios" && parseInt(Platform.Version, 10)>=15) ? 'Courier New' : 'Courier';
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please test on ios