Improve huge_patch test #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to measure time of test data preparation because it could be slow in some python interpreters, depending on how string concatenation is implemented.
Data preparation for huge_patch test could be very slow because strings are immutable, each concatenation creates a new string and discards the old ones. New approach of data preparation is to concatenate large string from smaller parts with ''.join() method. This method reduces memory usage and enhances performance, because it minimizes the number of new string objects created.
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jun 20, 2024
The huge_patch test measures performance of the parser together with test data preparation. It could take long time in some interpreters, therefore, let's deselect it. This is also related to [1], which addresses test problems. [1] cscorley/whatthepatch#60 Closes: https://bugs.gentoo.org/907243 Signed-off-by: Petr Vaněk <[email protected]>
|
Agree. The test must check parse time. |
|
Looks good to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The huge_patch test can fail in some python interpreters, e.g. pypy3 or python3.13 in my case, because text data preparation can take long time as it could be very memory intensive.
This PR addresses the issue with following two changes:
start_timemeasurement to measure only the parsing time but not data preparation. In other words, test will pass even if the test data preparation will take long time.''.join()method, which is more efficient because it minimizes the number of new string objects created.The PR is related to #46
See also https://bugs.gentoo.org/907243