Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just some minor performance improvements and warning fixes #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FlorianPfaff
Copy link

Hi,
since I'm currently experimenting with your code with spherical harmonics and made some minor improvements, I just thought I'd as well make them available (considering this github project is public).
Most changes are just fixes for Matlab editor warnings for reducing the use of defval. Some additional notes:

  1. The code should be fully backwards compatible to yours. I added the possibility to put the files for LEGENDRE in the subfolder located where the xyz2plm.m file is located but set it to false by default.
  2. I just put my name in "last modified by" to be consistent with the utilized convention, feel free copy the changes to your branch and put your name there.
  3. I assume the datafit is the one available as part of slepian_bravo. I changed the function call because that makes it more pretty to eliminate defval statements over there as well.

Greetings,

Florian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant