feat: add options page #158

ayoung19 · 2023-07-19T09:12:28Z

TODO:

open options page from market still doesnt work in firefox

Step7750

Page layout looks good!

There's a couple of remaining pieces

System for fetching/storing settings (with defaults defined)
Defining settings for each piece, hooking it to the relevant function
Adding a "easy" settings button in some places of the UI (ie. in the little float bar in the Steam Market)

I think we should create a new WIP branch to merge the settings PRs into until it is ready for deployment. Otherwise, it makes it difficult to create releases on master.

src/pages/wow/index.html

ayoung19 · 2023-07-20T06:28:24Z

oh i was planning on finishing up the pr on this branch and merging it when it's ready, it's still kind of a draft

Step7750 · 2023-07-20T06:54:39Z

Converted to a draft PR in the meantime, please click Ready for review when you're ready!

Putting it all in one PR is fine with me.

src/background.ts

src/lib/components/market/skin_viewer.ts

src/lib/bridge/handlers/open_options_page.ts

src/lib/components/market/skin_viewer.ts

Step7750 · 2023-07-23T02:07:37Z

src/pages/options/settings/MarketSettings.tsx

+                <Flex direction="column" w={500}>
+                    <Title order={6}>3D/Screenshot Buttons</Title>
+                    <Text fz="xs">
+                        Shows buttons under a listing to quickly view 3d model or screenshot of the specific item.


If we define the options that are possible in a schema (or just their own Setting<name, type, data_type>), then we can also define the description and auto-generate the entire page here.

Adding new settings would become super-simple, just adding the new defined Setting option and it all "hooks" up and allows toggling it here.

i agree it would be really nice once we’ve fleshed out more settings and define specific data types but it feels like an over optimization right now

would it be fair to add this once we have a third repeating data type for our settings

actually at the very least i’ll component-ize this boolean setting field rn

Sure, I think my solution is a bit of over-engineering for this. But yeah, let's prioritize making it simple to add new options fields.

src/lib/bridge/handlers/open_options_page.ts

Step7750

It seems like the PR doesn't build:

[webpack-cli] HookWebpackError: Maximum call stack size exceeded

Also looks like the build rule caught a circular dependency.

package.json

This reverts commit 66c5688.

dduart3 · 2024-03-09T15:49:27Z

May I know if this PR is going to be merged?

dduart3 · 2024-03-09T15:49:42Z

@Step7750

Step7750 · 2024-03-09T18:54:00Z

May I know if this PR is going to be merged?

I believe there were some issues with getting this to run properly on Firefox at one point. If you'd like to fork it, feel free.

ayoung19 · 2024-03-09T19:09:13Z

Also one of the build tools that checks for import cycles wasn't happy, I can take a look there really only is like 1% left to get this merged.

dduart3 · 2024-03-09T19:24:30Z

Also one of the build tools that checks for import cycles wasn't happy, I can take a look there really only is like 1% left to get this merged.

I was just checking this branch, it looked good and built correctly, I was looking to create something like this but this is already too advanced to be discarded imo. I would just change some minor details and add a couple options that I have in mind already.

I'm not sure at all about the issue you're mentioning, it already passed the checks but I would love to see this being merged or approved for merge at least

ayoung19 · 2024-03-09T19:54:24Z

Basically the CI has a circular dependency check that isn't passing because it doesn't seem to like the import cycles that exist in React (which is normal).

But yeah how about I try fix up those two small issues preventing it to be merged and then you can build on top of that.

dduart3 · 2024-03-09T19:57:06Z

Basically the CI has a circular dependency check that isn't passing because it doesn't seem to like the import cycles that exist in React (which is normal).

But yeah how about I try fix up those two small issues preventing it to be merged and then you can build on top of that.

Sounds really good man, would be happy to help if you need it of course

ayoung19 · 2024-03-09T19:58:32Z

Yeah the bigger issue is the link to the options page (from the listing page) doesn't work on Firefox for whatever reason... A fresh pair of eyes may help with that.

dduart3 · 2024-03-09T20:08:59Z

Yeah the bigger issue is the link to the options page (from the listing page) doesn't work on Firefox for whatever reason... A fresh pair of eyes may help with that.

Sure thing man, I'll look into it

ayoung19 · 2024-03-09T20:34:28Z

@Step7750 Omg... This was the problem the whole time 😭

extension/src/lib/bridge/client.ts

Line 8 in 262a725

return !(isFirefox() && inPageContext());

dduart3 · 2024-03-10T00:04:43Z

@Step7750 Omg... This was the problem the whole time 😭

extension/src/lib/bridge/client.ts

Line 8 in 262a725

return !(isFirefox() && inPageContext());

is it working now? haha

ayoung19 · 2024-03-11T20:57:25Z

No, I totally missed that the content script <-> background messaging isn't supported for firefox. @Step7750 any input on how you want this to be fixed?

Step7750 · 2024-11-15T01:51:42Z

No, I totally missed that the content script <-> background messaging isn't supported for firefox. @Step7750 any input on how you want this to be fixed?

Sorry, it has been a long time (hope you're doing well @ayoung19 !)

Content Script/Background Messaging is supported on Firefox using the postMessage fallback bus:

extension/src/lib/bridge/client.ts

Line 43 in 262a725

return g_PostMessageBus.sendRequest(bundle);

ayoung19 · 2024-12-11T07:28:31Z

@Step7750 Thanks and hope you're doing well too! Also yes you're right I took another look and found that it's because I was calling ClientSend(OpenOptionsPage, undefined) instead of ClientSend(OpenOptionsPage, {}). It works now!

Also I noticed the 3D screenshot buttons are gone now so it seems like that option is deprecated. Do you have a new options you'd like added? Would love to finally close this PR.

Add options page configs

1bc0221

Step7750 reviewed Jul 20, 2023

View reviewed changes

src/pages/wow/index.html Outdated Show resolved Hide resolved

Step7750 marked this pull request as draft July 20, 2023 06:53

ayoung19 added 4 commits July 20, 2023 01:29

Add settings manipulation

9663c8b

Add functionality

57ec431

Merge branch 'master' into feature/options-page

4c35d9d

Remove about page and inventory settings

40695fd

ayoung19 marked this pull request as ready for review July 20, 2023 22:30

Add settings button, still needs to support firefox

fc1c3d2

ayoung19 requested a review from Step7750 July 22, 2023 21:32

Step7750 requested changes Jul 23, 2023

View reviewed changes

Add suggestions

1071527

Step7750 reviewed Jul 28, 2023

View reviewed changes

src/lib/bridge/handlers/open_options_page.ts Outdated Show resolved Hide resolved

Add get/set wrappers

00b7ebc

ayoung19 requested a review from Step7750 August 3, 2023 08:17

ayoung19 added 5 commits August 3, 2023 01:19

Merge

5dce6e8

Merge

05bb8d3

CSGO -> CS

ed35677

Revert package/lock json

1e336cc

Readd dependencies

e5f6f49

ayoung19 force-pushed the feature/options-page branch from 822be1e to e5f6f49 Compare August 3, 2023 08:38

ayoung19 added 3 commits August 4, 2023 02:03

Support firefox manifest

86facc9

Update logo

5b0609a

Merge branch 'master' into feature/options-page

48a411c

Step7750 requested changes Aug 13, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

ayoung19 added 2 commits August 18, 2023 20:32

Merge

5f34f07

Import type

2bb645e

ayoung19 added 6 commits August 20, 2023 22:41

Update workflow

fde53b6

Merge branch 'master' into feature/options-page

153c7ff

Remove type import

34ea887

Remove fs

5291ae4

Attempt to fix package-lock json changes

66c5688

Revert "Attempt to fix package-lock json changes"

ac93406

This reverts commit 66c5688.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add options page #158

feat: add options page #158

ayoung19 commented Jul 19, 2023 •

edited

Loading

Step7750 left a comment

ayoung19 commented Jul 20, 2023

Step7750 commented Jul 20, 2023

Step7750 Jul 23, 2023

ayoung19 Jul 23, 2023

ayoung19 Jul 23, 2023

ayoung19 Jul 23, 2023

Step7750 Jul 28, 2023

Step7750 left a comment

dduart3 commented Mar 9, 2024

dduart3 commented Mar 9, 2024

Step7750 commented Mar 9, 2024

ayoung19 commented Mar 9, 2024

dduart3 commented Mar 9, 2024 •

edited

Loading

ayoung19 commented Mar 9, 2024

dduart3 commented Mar 9, 2024

ayoung19 commented Mar 9, 2024 •

edited

Loading

dduart3 commented Mar 9, 2024

ayoung19 commented Mar 9, 2024

dduart3 commented Mar 10, 2024

ayoung19 commented Mar 11, 2024

Step7750 commented Nov 15, 2024

ayoung19 commented Dec 11, 2024 •

edited

Loading

feat: add options page #158

Are you sure you want to change the base?

feat: add options page #158

Conversation

ayoung19 commented Jul 19, 2023 • edited Loading

Step7750 left a comment

Choose a reason for hiding this comment

ayoung19 commented Jul 20, 2023

Step7750 commented Jul 20, 2023

Step7750 Jul 23, 2023

Choose a reason for hiding this comment

ayoung19 Jul 23, 2023

Choose a reason for hiding this comment

ayoung19 Jul 23, 2023

Choose a reason for hiding this comment

ayoung19 Jul 23, 2023

Choose a reason for hiding this comment

Step7750 Jul 28, 2023

Choose a reason for hiding this comment

Step7750 left a comment

Choose a reason for hiding this comment

dduart3 commented Mar 9, 2024

dduart3 commented Mar 9, 2024

Step7750 commented Mar 9, 2024

ayoung19 commented Mar 9, 2024

dduart3 commented Mar 9, 2024 • edited Loading

ayoung19 commented Mar 9, 2024

dduart3 commented Mar 9, 2024

ayoung19 commented Mar 9, 2024 • edited Loading

dduart3 commented Mar 9, 2024

ayoung19 commented Mar 9, 2024

dduart3 commented Mar 10, 2024

ayoung19 commented Mar 11, 2024

Step7750 commented Nov 15, 2024

ayoung19 commented Dec 11, 2024 • edited Loading

ayoung19 commented Jul 19, 2023 •

edited

Loading

dduart3 commented Mar 9, 2024 •

edited

Loading

ayoung19 commented Mar 9, 2024 •

edited

Loading

ayoung19 commented Dec 11, 2024 •

edited

Loading