Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'Fritz' from the project, namespace, and NuGet package names #41

Open
2 of 3 tasks
csharpfritz opened this issue Feb 24, 2022 · 17 comments
Open
2 of 3 tasks
Labels
enhancement New feature or request

Comments

@csharpfritz
Copy link
Owner

csharpfritz commented Feb 24, 2022

  • Project Name renamed
  • Namespace renamed
  • NuGet package renamed
@csharpfritz csharpfritz added the enhancement New feature or request label Feb 24, 2022
@ChristianWeyer
Copy link

Nice little project, @csharpfritz :-)

Do you also consider renaming it to more reflect the fact that it is not about APIs per se - but more like data-driven (or CRUD?) APIs? The DB-/DbContext-centric approach implies a certain kind of use case and usage patterns when it comes to APIs - and thus should püorbably be reflected in the lib name.

@csharpfritz
Copy link
Owner Author

With the introduction of the JSON APIs in this preview version I published today, there are now more ways to create APIs to expose data.

I think the name "InstantAPIs" reflects what a developer wants to create: Web APIs with 1 or 2 lines of code.

@ChristianWeyer
Copy link

Thanks for your thoughts, Jeff.

@csharpfritz
Copy link
Owner Author

I appreciate the discussion and different point of view.

@csharpfritz
Copy link
Owner Author

I think I'll go through this rename today on stream

@ScottKane
Copy link
Contributor

Created PR #62 for this

@davidbuckleyni
Copy link
Contributor

I like the name RapidAdaptiveApi meaning that while its instant also custom.

@davidbuckleyni
Copy link
Contributor

Created PR #62 for this @ScottKane as fritz said on stream reach out first and dicuss with him u missed a comment he was going to do the rename as part of the stream. As fritz said its good etiquette to ask them first.

@ScottKane
Copy link
Contributor

@davidbuckleyni that doesn't really fit with how git works, accept the PR or don't. I did exactly what was described in the issue. Also if you notice there is a comment from 25 days ago saying the same thing about doing it on stream, yet it was still up for grabs today...

@ScottKane
Copy link
Contributor

Also I think you should drop the s from InstantAPIs and rename to InstantApi (gotta be pascal even though acronyms feel wrong)

@davidbuckleyni
Copy link
Contributor

I am just going by what firtz said in his stream yesterday @ScottKane i think he will need to raise it again

@ScottKane
Copy link
Contributor

I watched the stream. What he said about etiquette was in regards to people creating PR's that touch way more than they should is bad etiquette. This is normal in open source so I am more that happy submitting a PR against an open issue doing exactly what it describes and nothing more.

@ScottKane
Copy link
Contributor

Not to mention renaming is a boring laborious task and I'm sure @csharpfritz would rather cover something more interesting.

@csharpfritz
Copy link
Owner Author

Thank you for the work on this patch, yes.. I wasn't able to get to it on stream and I'm glad to see the work to implement the change.

We need one more fix to go into the GitHub worklow to reference the new project names appropriately and then it can be merged... as well as deploy with the new NuGet name

@ScottKane
Copy link
Contributor

Should be good to go now :)

@csharpfritz
Copy link
Owner Author

Merged it... now going to rename the NuGet package

@rkmiecik
Copy link

rkmiecik commented Jun 11, 2022

@csharpfritz If I use this package now in my projetc, when you change the packages's name, my project will stop working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants