Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'Fritz' from the project, namespace, and NuGet package names #62

Merged
merged 6 commits into from
May 17, 2022

Conversation

ScottKane
Copy link
Contributor

That should be Fritz. removed from everywhere for #41

Not sure why the rename left the original but ok
@csharpfritz
Copy link
Owner

It looks like we also need the github worklow to be updated with the new project name

@ScottKane
Copy link
Contributor Author

Sorry I missed that, will get it sorted tonight.

@ScottKane
Copy link
Contributor Author

Fixed build.yaml and buildAndDeploy.yaml. Let me know if there's anything else I missed but I think that should be it.

@ScottKane
Copy link
Contributor Author

Not sure why this build is failing, can't find any further references to Fritz. in the project. Any ideas?

@verbedr
Copy link
Contributor

verbedr commented Apr 22, 2022

Hi @ScottKane,
The build action list all the references and using's to Fritz as an error. I cloned your repo and got the same result when performing "dotnet build" in the root of the repository.

I'm not sure how you are looking for the references to "Fritz.", but I would suggest by starting a solution wide search to "Fritz."

Some reference I found:

This is not the complete list, but just a small sample to help you find why you can't find them. I hope this helps

Kr
Dries

@ScottKane
Copy link
Contributor Author

ScottKane commented Apr 22, 2022

Unsure what happened with the last commit, the changes were made but half of them had been stashed for some reason. Had to remove using Mock; from TestJson/Program.cs as that was causing the build to fail, not sure how that ever worked as the project has no Mock dependency? There was also a load of unused using directives throughout the solution but I thought it best to leave them for now. This is the only one I touched.

@verbedr
Copy link
Contributor

verbedr commented Apr 23, 2022

Don't worry about it. It happens to me also, and this is one of the purpose of having the CI. As a tip, when this happens to me, I tend to use rebase and reorganize the commits so nobody notices my mistake...

On another note, can you remove the .idea folder from the commits and put this folder in the .gitignore file? @csharpfritz I guess we will not standardize on that IDEA tool, and just like for visual code we do not include the cache/config folder ".vs/".

@ScottKane
Copy link
Contributor Author

Done, I'm surprised .idea isn't already ignored in the gitignore template next to .vs at this point but should be fine going forward.

@csharpfritz csharpfritz merged commit 5fb5a53 into csharpfritz:main May 17, 2022
@csharpfritz
Copy link
Owner

Thank you for the work on this... this was not an easy patch to complete, and I really appreciate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants