Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23_ReactIntegration #26

Merged
merged 2 commits into from
Oct 18, 2023
Merged

23_ReactIntegration #26

merged 2 commits into from
Oct 18, 2023

Conversation

kevintamakuwala
Copy link
Contributor

Minor bug fix:

  • Removed build from .gitignore
  • built the project

This should work now, it is working on test env

@github-actions
Copy link

Hello! 👋 Thank you @kevintamakuwala for your pull request!
We appreciate your contribution to "Frontend-Treasure" for Hacktoberfest. Your effort helps make our project better. 🌟
Our team will review your PR soon. In the meantime, feel free to explore more ways to contribute or join our community discussions. Your involvement is important to us!
Keep up the great work! 🚀

@Nisarg155 Nisarg155 merged commit f951c00 into csiddu:main Oct 18, 2023
1 check passed
@Nisarg155
Copy link
Member

Nisarg155 commented Oct 18, 2023

@kevintamakuwala it working !!
issue no #23

@kevintamakuwala kevintamakuwala deleted the 23_kevintamakuwala branch October 18, 2023 07:10
@kevintamakuwala
Copy link
Contributor Author

Just one suggestion, documentation needs to be improved.

@Nisarg155
Copy link
Member

what changes should be made ?
Can you elaborate...

@kevintamakuwala
Copy link
Contributor Author

kevintamakuwala commented Oct 18, 2023

Like follow standard practices of writing documentation. eg:

  • Description of project should be very precise and short.
  • Write certain guidelines of maintaining folder structure and code quality.
  • Impose necessary checks on PRs.
  • Give entire workflow of creating React Component (which i mentioned) along with workflow of HTML.
  • Readme should include only important and necessary information and no jargons.

Besides,

  • Like you have mentioned tech stacks in Readme, integrate all of them with HTML project (very difficult for new commers). I did it for React.
  • Provide guidelines for production and building projects.

You can raise an issue for improving documentations and make it as good-first-issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants