Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attendances without using Serializers #393

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Veriny
Copy link

@Veriny Veriny commented Feb 17, 2023

Resolves #389.

Update attendance models directly when updating attendances to avoid errors when coordinators update attendances for students who have not logged in yet.

@Veriny Veriny changed the title fix for issue389 Update attendances without using Serializers Feb 17, 2023
@cypress
Copy link

cypress bot commented Feb 17, 2023

1 failed tests on run #93 ↗︎

1 77 0 0 Flakiness 0

Details:

Update attendances without using Serializers
Project: csm_web Commit: a981a97236
Status: Failed Duration: 02:27 💡
Started: Mar 13, 2023 6:28 PM Ended: Mar 13, 2023 6:31 PM
Failed  cypress/e2e/course/restricted-courses.cy.ts • 1 failed test • Tests on Chrome 106

View Output Video

Test Artifacts
whitelisted courses > should see and enroll in whitelisted courses and sections Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@Veriny Veriny linked an issue Feb 17, 2023 that may be closed by this pull request
Copy link
Member

@smartspot2 smartspot2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good overall; could you also create tests (Cypress and pytest) for manually adding students to sections, and attempting to take attendance for them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Students who have not logged in cannot have their attendances taken
2 participants