Add Luxon, refactor date parsing/formatting #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
o this is cool wow |
Passing run #157 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
smartspot2
force-pushed
the
feat/luxon
branch
3 times, most recently
from
4df9fc7
to
ab0fc7a
Compare
Use luxon for enrollment automation implementation Update resource aggregation date display
|
i test and i like date format. |
ericyche
approved these changes
Aug 6, 2023
edwardneo
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #367
Default datetime support in JS is horrible, so Luxon was added to make it a lot easier to manage.
Further, there are some serializers which format dates in the response, which is bad convention, as the backend should provide dates in a standardized format (i.e. ISO), letting the frontend do the formatting; parsing should be made as easy as possible. This was changed in this PR so that serializers give all date/datetime values in ISO.