-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to SCSS #429
Migrate to SCSS #429
Conversation
Passing run #200 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
9221f25
to
d93bb10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good! I don't know too much about Cypress, so I'll let Eric take a deeper look at that.
it works on my end but i'll take another look after conflicts are resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it good. thank you alec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me -- rebase and merge!
Add base styles for buttons, modals, forms, etc. Split original styles file into multiple grouped files Modify styles and classes to be more consistent Set up webpack for CSS compilation Move style files out of static folder
Closes #345.
The existing CSS organization sucks: there was one huge
styles.css
file, containing a messy mashup of various styles for various components. We had begun using separate CSS files later on, but the weird dependencies between classes across all of these files, along with bad defaults created a lot of duplicated CSS code.This PR aims to make the styles a lot more organized, utilizing SCSS to allow for more advanced functionality.
styles.css
file is deleted.In the future (as this PR is long enough as is), we can think about adding scoped styling, forcing styles to be imported explicitly in each component file. This would protect against any name clashes (with automatic suffixes added to each class), and also ensures that we import all of the styles we need, rather than silently stealing styles from other components.
(This is a beefy PR, but the vast majority of the changes are just copying over CSS styles to new files, and from the
package-lock.json
file changes.)