Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only untaken attendances are deleted when student is dropped #444

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Veriny
Copy link

@Veriny Veriny commented Sep 19, 2023

When students are dropped, they lose their attendances for the current day, even if their attendance has already been taken. This change makes it so that attendances for the day are only deleted when the section is later in the day (i.e. attendance has not been taken)

@cypress
Copy link

cypress bot commented Sep 19, 2023

Passing run #214 ↗︎

0 78 0 0 Flakiness 0

Details:

Only untaken attendances are deleted when student is dropped
Project: csm_web Commit: 7b14e71160
Status: Passed Duration: 02:28 💡
Started: Sep 19, 2023 3:49 AM Ended: Sep 19, 2023 3:51 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

…n students are dropped

pre-commit fixes

fix merge conflict
Copy link
Member

@smartspot2 smartspot2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, this doesn't actually fix the issue, since the mentor could still have left attendances blank when the student drops the section; we should only delete attendances if they're actually in the future. This would require some additional checking for attendances on the day of the drop, to check whether the user dropped the section after the section time or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Students who drop their section lose the attendance from the current day
2 participants